Remove associated keying material when unregistering from GCM

components/gcm_driver/crypto/gcm_key_store.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/gcm_driver/crypto/gcm_key_store.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 124 matching lines @@
     callback.Run(KeyPair(), std::string() /* auth_secret */);
     return;
   }
 
   key_pairs_[app_id] = pair;
   auth_secrets_[app_id] = auth_secret;
 
   callback.Run(key_pairs_[app_id], auth_secret);
 }
 
-void GCMKeyStore::DeleteKeys(const std::string& app_id,
-                             const DeleteCallback& callback) {
-  LazyInitialize(base::Bind(&GCMKeyStore::DeleteKeysAfterInitialize,
+void GCMKeyStore::RemoveKeys(const std::string& app_id,
+                             const base::Closure& callback) {
+  LazyInitialize(base::Bind(&GCMKeyStore::RemoveKeysAfterInitialize,
                             weak_factory_.GetWeakPtr(), app_id, callback));
 }
 
-void GCMKeyStore::DeleteKeysAfterInitialize(const std::string& app_id,
-                                            const DeleteCallback& callback) {
+void GCMKeyStore::RemoveKeysAfterInitialize(const std::string& app_id,
+                                            const base::Closure& callback) {
   DCHECK(state_ == State::INITIALIZED || state_ == State::FAILED);
   const auto iter = key_pairs_.find(app_id);
   if (iter == key_pairs_.end() || state_ != State::INITIALIZED) {
-    callback.Run(true /* success */);
+    callback.Run();
     return;
   }
 
   using EntryVectorType =
       leveldb_proto::ProtoDatabase<EncryptionData>::KeyEntryVector;
 
   scoped_ptr<EntryVectorType> entries_to_save(new EntryVectorType());
   scoped_ptr<std::vector<std::string>> keys_to_remove(
       new std::vector<std::string>(1, app_id));
 
   database_->UpdateEntries(
       std::move(entries_to_save), std::move(keys_to_remove),
-      base::Bind(&GCMKeyStore::DidDeleteKeys, weak_factory_.GetWeakPtr(),
+      base::Bind(&GCMKeyStore::DidRemoveKeys, weak_factory_.GetWeakPtr(),
                  app_id, callback));
 }
 
-void GCMKeyStore::DidDeleteKeys(const std::string& app_id,
-                                const DeleteCallback& callback,
+void GCMKeyStore::DidRemoveKeys(const std::string& app_id,
+                                const base::Closure& callback,
                                 bool success) {
-  if (!success) {
+  // TODO(peter): Add a histogram for tracking |success|.
+
+  if (success) {
+    key_pairs_.erase(app_id);
+    auth_secrets_.erase(app_id);
+  } else {
     DVLOG(1) << "Unable to delete a key from the GCM Key Store.";
-    callback.Run(false /* success */);
-    return;
   }
 
-  key_pairs_.erase(app_id);
-  auth_secrets_.erase(app_id);
-
-  callback.Run(true /* success */);
+  callback.Run();
 }
 
 void GCMKeyStore::LazyInitialize(const base::Closure& done_closure) {
   if (delayed_task_controller_.CanRunTaskWithoutDelay()) {
     done_closure.Run();
     return;
   }
 
   delayed_task_controller_.AddTask(done_closure);
   if (state_ == State::INITIALIZING)
@@ skipping 38 matching lines @@
     key_pairs_[entry.app_id()] = entry.keys(0);
     auth_secrets_[entry.app_id()] = entry.auth_secret();
   }
 
   state_ = State::INITIALIZED;
 
   delayed_task_controller_.SetReady();
 }
 
 }  // namespace gcm