Filter invalid slots after array trimming.

Filter invalid slots after array trimming.

If sweeping is in progress then we need to filter out slots in free space after
array trimming, because the sweeper will add the free space into free list.

This CL also fixes a bug in SlotSet::RemoveRange.

BUG=chromium:587004
LOG=NO
TBR=hpayer@chromium.org

Committed: https://crrev.com/017d128b6ea60fcadf675f53ee5e2ffe84c3a66c
Cr-Commit-Position: refs/heads/master@{#34071}

[ulan, 2016-02-16 19:42:24]

ulan@chromium.org changed reviewers:
+ hpayer@chromium.org

[ulan, 2016-02-16 19:42:25]

PTAL

https://codereview.chromium.org/1701963003/diff/1/src/heap/slot-set.h
File src/heap/slot-set.h (right):

https://codereview.chromium.org/1701963003/diff/1/src/heap/slot-set.h#newcode77
src/heap/slot-set.h:77: uint32_t current_bucket = start_bucket;
Rewrote these parts to make invariants more obvious.

https://codereview.chromium.org/1701963003/diff/1/src/heap/slot-set.h#newcode88
src/heap/slot-set.h:88: current_cell = 0;
This was the bug in this function.

https://codereview.chromium.org/1701963003/diff/1/test/cctest/heap/test-heap.cc
File test/cctest/heap/test-heap.cc (right):

https://codereview.chromium.org/1701963003/diff/1/test/cctest/heap/test-heap....
test/cctest/heap/test-heap.cc:6498: FLAG_verify_heap = false;
Verify heap forces sweeping to finish during MarkCompact.

[ulan, 2016-02-17 10:08:13]

Description was changed from

==========
Filter invalid slots after array trimming.

If sweeping is in progress then we need to filter out slots in free space after
array trimming, because the sweeper will add the free space into free list.

This CL also fixes a bug in SlotSet::RemoveRange.

BUG=chromium:587004
LOG=NO
==========

to

==========
Filter invalid slots after array trimming.

If sweeping is in progress then we need to filter out slots in free space after
array trimming, because the sweeper will add the free space into free list.

This CL also fixes a bug in SlotSet::RemoveRange.

BUG=chromium:587004
LOG=NO
TBR=hpayer@chromium.org
==========

[ulan, 2016-02-17 10:09:15]

Hannes, I am going to land this now with tbr and will address your comments (if
any) in a separate CL.

[ulan, 2016-02-17 10:09:51]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2016-02-17 10:10:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1701963003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1701963003/40001

[commit-bot: I haz the power, 2016-02-17 10:38:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 10:38:55]

Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)

[ulan, 2016-02-17 11:21:30]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2016-02-17 11:21:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1701963003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1701963003/60001

[commit-bot: I haz the power, 2016-02-17 11:25:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 11:25:06]

Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/13882)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_win_compile_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/1...)

[ulan, 2016-02-17 11:26:25]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2016-02-17 11:26:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1701963003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1701963003/80001

[commit-bot: I haz the power, 2016-02-17 11:52:36]

Description was changed from

==========
Filter invalid slots after array trimming.

If sweeping is in progress then we need to filter out slots in free space after
array trimming, because the sweeper will add the free space into free list.

This CL also fixes a bug in SlotSet::RemoveRange.

BUG=chromium:587004
LOG=NO
TBR=hpayer@chromium.org
==========

to

==========
Filter invalid slots after array trimming.

If sweeping is in progress then we need to filter out slots in free space after
array trimming, because the sweeper will add the free space into free list.

This CL also fixes a bug in SlotSet::RemoveRange.

BUG=chromium:587004
LOG=NO
TBR=hpayer@chromium.org
==========

[commit-bot: I haz the power, 2016-02-17 11:52:37]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-17 11:53:14]

Description was changed from

==========
Filter invalid slots after array trimming.

If sweeping is in progress then we need to filter out slots in free space after
array trimming, because the sweeper will add the free space into free list.

This CL also fixes a bug in SlotSet::RemoveRange.

BUG=chromium:587004
LOG=NO
TBR=hpayer@chromium.org
==========

to

==========
Filter invalid slots after array trimming.

If sweeping is in progress then we need to filter out slots in free space after
array trimming, because the sweeper will add the free space into free list.

This CL also fixes a bug in SlotSet::RemoveRange.

BUG=chromium:587004
LOG=NO
TBR=hpayer@chromium.org

Committed: https://crrev.com/017d128b6ea60fcadf675f53ee5e2ffe84c3a66c
Cr-Commit-Position: refs/heads/master@{#34071}
==========

[commit-bot: I haz the power, 2016-02-17 11:53:15]

Patchset 5 (id:??) landed as
https://crrev.com/017d128b6ea60fcadf675f53ee5e2ffe84c3a66c
Cr-Commit-Position: refs/heads/master@{#34071}