Unwrap TypeRef returned by InstantiateFrom in AssertAssignableInstr::Canonicalize.

Unwrap TypeRef returned by InstantiateFrom in AssertAssignableInstr::Canonicalize.

Runtime system does not expect to see TypeRef as a destination type for a
type check: type references should only appear in the type arguments of
recursive types.

Reorganize canonicalization code to make it more readable and assertions to
catch this issue earlier.

BUG=http://dartbug.com/25782
R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/b2994a4f556a13d6420b122a97ceef739f427653

[Vyacheslav Egorov (Google), 2016-02-16 12:00:11]

vegorov@google.com changed reviewers:
+ fschneider@google.com

[Vyacheslav Egorov (Google), 2016-02-16 12:00:11]

PTAL

[Florian Schneider, 2016-02-16 12:13:43]

lgtm

[Vyacheslav Egorov (Google), 2016-02-16 12:44:11]

Description was changed from

==========
Unwrap TypeRef returned by InstantiateFrom in
AssertAssignableInstr::Canonicalize.

Runtime system does not expect to see TypeRef as a destination type for a
type check: type references should only appear in the type arguments of
recursive types.

Reorganize canonicalization code to make it more readable and assertions to
catch this issue earlier.

BUG=http://dartbug.com/25782
==========

to

==========
Unwrap TypeRef returned by InstantiateFrom in
AssertAssignableInstr::Canonicalize.

Runtime system does not expect to see TypeRef as a destination type for a
type check: type references should only appear in the type arguments of
recursive types.

Reorganize canonicalization code to make it more readable and assertions to
catch this issue earlier.

BUG=http://dartbug.com/25782
R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b2994a4f556a13d6420b122a97ceef739f427653
==========

[Vyacheslav Egorov (Google), 2016-02-16 12:44:12]

Committed patchset #1 (id:1) manually as
b2994a4f556a13d6420b122a97ceef739f427653 (presubmit successful).