Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1701933004: Remove the old package manager (Closed)

Created:
4 years, 10 months ago by Ben Goodger (Google)
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@am2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the old package manager BUG= Committed: https://crrev.com/41f2fe9d2925a4cb17582dfa974217f5765e83d5 Cr-Commit-Position: refs/heads/master@{#376064}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -4057 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 2 chunks +1 line, -7 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M mojo/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/mojo_shell.gyp View 2 chunks +2 lines, -46 lines 0 comments Download
M mojo/shell/BUILD.gn View 4 chunks +2 lines, -17 lines 0 comments Download
M mojo/shell/application_manager.h View 9 chunks +21 lines, -26 lines 0 comments Download
M mojo/shell/application_manager.cc View 1 2 10 chunks +64 lines, -142 lines 0 comments Download
M mojo/shell/application_manager_unittest.cc View 1 2 4 chunks +6 lines, -21 lines 0 comments Download
M mojo/shell/background/background_shell.cc View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/shell/capability_filter_test.h View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/shell/capability_filter_test.cc View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/shell/capability_filter_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M mojo/shell/connect_util.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A + mojo/shell/content_handler_connection.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/shell/content_handler_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/shell/data_pipe_peek.h View 1 chunk +0 lines, -40 lines 0 comments Download
D mojo/shell/data_pipe_peek.cc View 1 chunk +0 lines, -163 lines 0 comments Download
D mojo/shell/data_pipe_peek_unittest.cc View 1 chunk +0 lines, -133 lines 0 comments Download
D mojo/shell/fetcher.h View 1 chunk +0 lines, -82 lines 0 comments Download
D mojo/shell/fetcher.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D mojo/shell/fetcher/BUILD.gn View 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/shell/fetcher/DEPS View 1 chunk +0 lines, -17 lines 0 comments Download
D mojo/shell/fetcher/about_fetcher.h View 1 chunk +0 lines, -60 lines 0 comments Download
D mojo/shell/fetcher/about_fetcher.cc View 1 chunk +0 lines, -116 lines 0 comments Download
D mojo/shell/fetcher/about_fetcher_unittest.cc View 1 chunk +0 lines, -196 lines 0 comments Download
D mojo/shell/fetcher/data_fetcher.h View 1 chunk +0 lines, -52 lines 0 comments Download
D mojo/shell/fetcher/data_fetcher.cc View 1 chunk +0 lines, -119 lines 0 comments Download
D mojo/shell/fetcher/data_fetcher_unittest.cc View 1 chunk +0 lines, -119 lines 0 comments Download
D mojo/shell/fetcher/local_fetcher.h View 1 chunk +0 lines, -65 lines 0 comments Download
D mojo/shell/fetcher/local_fetcher.cc View 1 chunk +0 lines, -153 lines 0 comments Download
D mojo/shell/fetcher/network_fetcher.h View 1 chunk +0 lines, -88 lines 0 comments Download
D mojo/shell/fetcher/network_fetcher.cc View 1 chunk +0 lines, -253 lines 0 comments Download
D mojo/shell/fetcher/network_fetcher_unittest.cc View 1 chunk +0 lines, -181 lines 0 comments Download
D mojo/shell/fetcher/switches.h View 1 chunk +0 lines, -18 lines 0 comments Download
D mojo/shell/fetcher/switches.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D mojo/shell/fetcher/url_resolver.h View 1 chunk +0 lines, -42 lines 0 comments Download
D mojo/shell/fetcher/url_resolver.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D mojo/shell/fetcher/url_resolver_unittest.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M mojo/shell/identity.cc View 2 chunks +3 lines, -5 lines 0 comments Download
D mojo/shell/package_manager.h View 1 chunk +0 lines, -78 lines 0 comments Download
D mojo/shell/package_manager/BUILD.gn View 1 chunk +0 lines, -42 lines 0 comments Download
D mojo/shell/package_manager/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/shell/package_manager/capability_filter_content_handler_unittest.cc View 1 chunk +0 lines, -160 lines 0 comments Download
D mojo/shell/package_manager/content_handler_connection.h View 1 chunk +0 lines, -67 lines 0 comments Download
D mojo/shell/package_manager/content_handler_connection.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D mojo/shell/package_manager/content_handler_unittest.cc View 1 chunk +0 lines, -328 lines 0 comments Download
D mojo/shell/package_manager/package_manager_impl.h View 1 chunk +0 lines, -166 lines 0 comments Download
D mojo/shell/package_manager/package_manager_impl.cc View 1 chunk +0 lines, -417 lines 0 comments Download
D mojo/shell/query_util.h View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/shell/query_util.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/shell/query_util_unittest.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M mojo/shell/standalone/BUILD.gn View 1 2 3 4 5 6 5 chunks +1 line, -16 lines 0 comments Download
M mojo/shell/standalone/context.h View 3 chunks +0 lines, -5 lines 0 comments Download
M mojo/shell/standalone/context.cc View 1 2 3 4 5 6 5 chunks +2 lines, -66 lines 0 comments Download
D mojo/shell/standalone/register_local_aliases.h View 1 2 3 4 5 6 1 chunk +0 lines, -17 lines 0 comments Download
D mojo/shell/standalone/register_local_aliases.cc View 1 2 3 4 5 6 1 chunk +0 lines, -13 lines 0 comments Download
M mojo/shell/switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/shell/switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/shell/test_package_manager.h View 1 chunk +0 lines, -51 lines 0 comments Download
D mojo/shell/test_package_manager.cc View 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
Ben Goodger (Google)
4 years, 10 months ago (2016-02-17 21:14:17 UTC) #3
Ben Goodger (Google)
On 2016/02/17 21:14:17, Ben Goodger (Google) wrote: I'll roll out elliot's change once it lands ...
4 years, 10 months ago (2016-02-17 21:14:39 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701933004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701933004/60001
4 years, 10 months ago (2016-02-17 21:16:16 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/23105) android_compile_dbg on ...
4 years, 10 months ago (2016-02-17 21:25:06 UTC) #7
sky
LGTM
4 years, 10 months ago (2016-02-17 21:27:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701933004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701933004/80001
4 years, 10 months ago (2016-02-17 21:42:58 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/23119) android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, ...
4 years, 10 months ago (2016-02-17 21:48:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701933004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701933004/100001
4 years, 10 months ago (2016-02-17 22:22:26 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/51428) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-17 22:42:37 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701933004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701933004/120001
4 years, 10 months ago (2016-02-18 00:41:16 UTC) #21
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 10 months ago (2016-02-18 02:10:30 UTC) #22
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 02:11:29 UTC) #24
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/41f2fe9d2925a4cb17582dfa974217f5765e83d5
Cr-Commit-Position: refs/heads/master@{#376064}

Powered by Google App Engine
This is Rietveld 408576698