Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1701933003: MIPS64: Fix '[turbofan] Add an operator to access the parent frame pointer'. (Closed)

Created:
4 years, 10 months ago by balazs.kilvady
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix '[turbofan] Add an operator to access the parent frame pointer'. Port fd8fd05cc5389a44a3d15ace0cf34b43369b758e Original commit message: This functionality is useful for stubs that need to walk the stack. The new machine operator, LoadParentFramePointer doesn't force the currently compiling method to have a frame in contrast to LoadFramePointer. Instead, it adapts accordingly when frame elision is possible, making efficient stack walks possible without incurring a performance penalty for small stubs that can benefit from frame elision. BUG= Committed: https://crrev.com/a7b315b50ca0e2dfb01efc63e108035a03073d07 Cr-Commit-Position: refs/heads/master@{#34066}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
balazs.kilvady
4 years, 10 months ago (2016-02-16 19:12:39 UTC) #2
akos.palfi.imgtec
lgtm
4 years, 10 months ago (2016-02-16 23:42:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701933003/1
4 years, 10 months ago (2016-02-17 09:43:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 10:09:55 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 10:10:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7b315b50ca0e2dfb01efc63e108035a03073d07
Cr-Commit-Position: refs/heads/master@{#34066}

Powered by Google App Engine
This is Rietveld 408576698