Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 1701883006: Clean up some of the includes following my refactoring patch. (Closed)

Created:
4 years, 10 months ago by Finnur
Modified:
4 years, 10 months ago
Reviewers:
Ted C, dgrogan, michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up some of the includes following my refactoring patch. Combination of removing unused includes, include-what-you-use and forward-decl'ing to move an include to the .cc file. BUG=579109 Committed: https://crrev.com/ef0ee244fb494199ab7cdc11b0138be07561bced Cr-Commit-Position: refs/heads/master@{#376014}

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/browser/android/preferences/website_preference_bridge.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/storage/storage_info_fetcher.h View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/storage/storage_info_fetcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/site_settings_handler.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Finnur
David, since this is mostly storage includes, can you review. Ted and Michael, can you ...
4 years, 10 months ago (2016-02-17 10:58:01 UTC) #3
dgrogan
lgtm
4 years, 10 months ago (2016-02-17 21:05:25 UTC) #4
michaelpg
lgtm
4 years, 10 months ago (2016-02-17 21:14:30 UTC) #5
Ted C
On 2016/02/17 21:14:30, michaelpg wrote: > lgtm android - lgtm
4 years, 10 months ago (2016-02-17 21:52:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701883006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701883006/20001
4 years, 10 months ago (2016-02-17 22:39:21 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 22:49:12 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 22:50:38 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ef0ee244fb494199ab7cdc11b0138be07561bced
Cr-Commit-Position: refs/heads/master@{#376014}

Powered by Google App Engine
This is Rietveld 408576698