Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1701873003: Let Instance::IsInstanceOf verify that the type we check against is not a (Closed)

Created:
4 years, 10 months ago by regis
Modified:
4 years, 10 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Let Instance::IsInstanceOf verify that the type we check against is not a TypeRef that should have been dereferenced at compile time. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/3475b60e3b5aae0c0695feb9043c7d710d18d7e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M runtime/vm/object.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
4 years, 10 months ago (2016-02-16 22:50:40 UTC) #2
srdjan
lgtm
4 years, 10 months ago (2016-02-16 23:00:20 UTC) #3
regis
4 years, 10 months ago (2016-02-16 23:02:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3475b60e3b5aae0c0695feb9043c7d710d18d7e6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698