Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1701843003: Fix the order of constructor wrappers - member of handle. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix the order of constructor wrappers - member of handle. This fixes 7 failing tests with SDK summary. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/a012e7085e3fb97a1b01d73432aea18bf95b6f6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 10 months ago (2016-02-16 22:59:29 UTC) #1
Brian Wilkerson
We should get rid of the need for these `is` tests, but in the meantime, ...
4 years, 10 months ago (2016-02-16 23:13:44 UTC) #2
scheglov
4 years, 10 months ago (2016-02-17 01:17:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a012e7085e3fb97a1b01d73432aea18bf95b6f6d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698