Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2588)

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 1701843002: ServiceWorker: Implement 'source' and 'origin' attributes of ExtendableMessageEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_focus_into_utils
Patch Set: clean up tests Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index a6cec8299002053ef0018c94dae0d65ad23e16bd..bba54263aee351c512a9e72b734db6721f8b1e5e 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -18,6 +18,7 @@
#include "content/child/notifications/notification_data_conversions.h"
#include "content/child/request_extra_data.h"
#include "content/child/service_worker/service_worker_dispatcher.h"
+#include "content/child/service_worker/service_worker_handle_reference.h"
#include "content/child/service_worker/service_worker_network_provider.h"
#include "content/child/service_worker/service_worker_provider_context.h"
#include "content/child/service_worker/service_worker_registration_handle_reference.h"
@@ -737,15 +738,33 @@ void ServiceWorkerContextClient::OnActivateEvent(int request_id) {
void ServiceWorkerContextClient::OnExtendableMessageEvent(
int request_id,
- const base::string16& message,
- const std::vector<TransferredMessagePort>& sent_message_ports,
- const std::vector<int>& new_routing_ids) {
+ const ServiceWorkerMsg_ExtendableMessageEvent_Params& params) {
TRACE_EVENT0("ServiceWorker",
"ServiceWorkerContextClient::OnExtendableMessageEvent");
blink::WebMessagePortChannelArray ports =
- WebMessagePortChannelImpl::CreatePorts(
- sent_message_ports, new_routing_ids, main_thread_task_runner_);
- proxy_->dispatchExtendableMessageEvent(request_id, message, ports);
+ WebMessagePortChannelImpl::CreatePorts(params.message_ports,
+ params.new_routing_ids,
+ main_thread_task_runner_);
+ if (params.source.client_info.IsValid()) {
+ blink::WebServiceWorkerClientInfo web_client =
+ ToWebServiceWorkerClientInfo(params.source.client_info);
+ proxy_->dispatchExtendableMessageEvent(
+ request_id, params.message, params.source_origin, ports, web_client);
+ return;
+ }
+
+ DCHECK(params.source.service_worker_info.IsValid());
+ scoped_ptr<ServiceWorkerHandleReference> handle =
+ ServiceWorkerHandleReference::Adopt(params.source.service_worker_info,
+ sender_.get());
+ ServiceWorkerDispatcher* dispatcher =
+ ServiceWorkerDispatcher::GetOrCreateThreadSpecificInstance(
+ sender_.get(), main_thread_task_runner_.get());
+ scoped_refptr<WebServiceWorkerImpl> worker =
+ dispatcher->GetOrCreateServiceWorker(std::move(handle));
+ proxy_->dispatchExtendableMessageEvent(
+ request_id, params.message, params.source_origin, ports,
+ WebServiceWorkerImpl::CreateHandle(worker));
}
void ServiceWorkerContextClient::OnInstallEvent(int request_id) {

Powered by Google App Engine
This is Rietveld 408576698