third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event-async-respond-with.html - Issue 1701843002: ServiceWorker: Implement 'source' and 'origin' attributes of ExtendableMessageEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event-async-respond-with.html

Issue 1701843002: ServiceWorker: Implement 'source' and 'origin' attributes of ExtendableMessageEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_focus_into_utils

Patch Set: fix oilpan build Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/service_worker/service_worker_types.h ('K') | « third_party/WebKit/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/resources/extendable-message-event-worker.js ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event-respond-with-stops-propagation.html » ('j') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event-async-respond-with.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event-async-respond-with.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event-async-respond-with.html

index c27fbd597eaaf5e8bbfcec80d9437cce645bd811..f911041ef224730f8a1978e469c537deac77cdd5 100644

--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event-async-respond-with.html

+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event-async-respond-with.html

@@ -16,13 +16,13 @@ promise_test(function(t) {

return with_iframe(scope);

})

.then(function(frame) {

+ add_completion_callback(function() { frame.remove(); });

var channel = new MessageChannel();

var saw_message = new Promise(function(resolve) {

channel.port1.onmessage = function(e) { resolve(e.data); }

});

var worker = frame.contentWindow.navigator.serviceWorker.controller;

- frame.remove();

worker.postMessage({port: channel.port2}, [channel.port2]);

return saw_message;

})