tools/perf/metrics/timeline.py - Issue 170183004: Move smoothness to the new API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/metrics/timeline.py

Issue 170183004: Move smoothness to the new API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@submit

Patch Set: Reset actions list. Modify repaint measurement. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/metrics/timeline.py

diff --git a/tools/perf/metrics/timeline.py b/tools/perf/metrics/timeline.py

index 9313d99fe6aba852c87659d12267f433f217ea21..89b1b7f336c799455c7a14ef5f6b374d4db5f1a1 100644

--- a/tools/perf/metrics/timeline.py

+++ b/tools/perf/metrics/timeline.py

@@ -51,7 +51,12 @@ class TimelineMetric(Metric):

if self._mode == TRACING_MODE:

if not tab.browser.supports_tracing:

raise Exception('Not supported')

- tab.browser.StartTracing(self.trace_categories)

+ if self.trace_categories:

+ categories = [self.trace_categories] + \

+ page.GetSyntheticDelayCategories()

+ else:

+ categories = page.GetSyntheticDelayCategories()

+ tab.browser.StartTracing(','.join(categories))

else:

assert self._mode == TIMELINE_MODE

tab.StartTimelineRecording()