Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/perf/measurements/timeline_based_measurement_unittest.py

Issue 170183004: Move smoothness to the new API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@submit
Patch Set: Reset actions list. Modify repaint measurement. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/timeline_based_measurement.py ('k') | tools/perf/metrics/smoothness.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/timeline_based_measurement_unittest.py
diff --git a/tools/perf/measurements/timeline_based_measurement_unittest.py b/tools/perf/measurements/timeline_based_measurement_unittest.py
index 8c7959375a5829ad0864aef49d88fb3f04a4dd7b..694e0a80ff2a42b93cea54152c62667bb73b89c7 100644
--- a/tools/perf/measurements/timeline_based_measurement_unittest.py
+++ b/tools/perf/measurements/timeline_based_measurement_unittest.py
@@ -57,15 +57,13 @@ class TimelineBasedMetricsTests(unittest.TestCase):
class FakeSmoothMetric(timeline_based_metric.TimelineBasedMetric):
def AddResults(self, model, renderer_thread,
interaction_record, results):
- results.Add(
- interaction_record.GetResultNameFor('FakeSmoothMetric'), 'ms', 1)
+ results.Add('FakeSmoothMetric', 'ms', 1)
class FakeLoadingMetric(timeline_based_metric.TimelineBasedMetric):
def AddResults(self, model, renderer_thread,
interaction_record, results):
assert interaction_record.logical_name == 'LogicalName2'
- results.Add(
- interaction_record.GetResultNameFor('FakeLoadingMetric'), 'ms', 2)
+ results.Add('FakeLoadingMetric', 'ms', 2)
class TimelineBasedMetricsWithFakeMetricHandler(
tbm_module._TimelineBasedMetrics): # pylint: disable=W0212
@@ -90,9 +88,9 @@ class TimelineBasedMetricsTests(unittest.TestCase):
metric.AddResults(results)
results.DidMeasurePage()
- v = results.FindAllPageSpecificValuesNamed('LogicalName1/FakeSmoothMetric')
+ v = results.FindAllPageSpecificValuesNamed('LogicalName1-FakeSmoothMetric')
self.assertEquals(len(v), 1)
- v = results.FindAllPageSpecificValuesNamed('LogicalName2/FakeLoadingMetric')
+ v = results.FindAllPageSpecificValuesNamed('LogicalName2-FakeLoadingMetric')
self.assertEquals(len(v), 1)
@@ -105,9 +103,15 @@ class TimelineBasedMeasurementTest(
def testTimelineBasedForSmoke(self):
ps = self.CreatePageSetFromFileInUnittestDataDir(
'interaction_enabled_page.html')
- setattr(ps.pages[0], 'smoothness', {'action': 'wait',
- 'javascript': 'window.animationDone'})
+ setattr(ps.pages[0], 'smoothness', [{'action': 'scroll'},
+ {'action': 'wait',
+ 'javascript': 'window.animationDone'}])
measurement = tbm_module.TimelineBasedMeasurement()
results = self.RunMeasurement(measurement, ps,
options=self._options)
self.assertEquals(0, len(results.failures))
+ v = results.FindAllPageSpecificValuesNamed('CenterAnimation-jank')
+ self.assertEquals(len(v), 2)
+ v = results.FindAllPageSpecificValuesNamed('DrawerAnimation-jank')
+ self.assertEquals(len(v), 2)
+
« no previous file with comments | « tools/perf/measurements/timeline_based_measurement.py ('k') | tools/perf/metrics/smoothness.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698