Move smoothness to the new API

tools/perf/metrics/timeline_interaction_record.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 
 
 def IsTimelineInteractionRecord(event_name):
   return event_name.startswith('Interaction.')
 
@@ skipping 28 matching lines @@
      setTimeout(function() {
        console.timeEnd(str);
      }, 1000);
 
   When run with perf.measurements.timeline_based_measurement running, this will
   then cause a TimelineInteractionRecord to be created for this range and both
   smoothness and network metrics to be reported for the marked up 1000ms
   time-range.
 
   """
-  def __init__(self, event):
-    self.start = event.start
-    self.end = event.end
+  def __init__(self, start, end):
+    self.start = start

[nduca, 2014/03/07 20:05:56]

i'd like logical_name to be mandatory

+    self.end = end
+    self.logical_name = ''
+    self.is_smooth = False
+    self.is_loading_resources = False
 
+  @staticmethod
+  def FromEvent(event):
+    record = TimelineInteractionRecord(event.start, event.end)
     m = re.match('Interaction\.(.+)\/(.+)', event.name)
     if m:
-      self.logical_name = m.group(1)
+      record.logical_name = m.group(1)
       if m.group(1) != '':
         flags = m.group(2).split(',')
       else:
         flags = []
     else:
       m = re.match('Interaction\.(.+)', event.name)
       assert m
-      self.logical_name = m.group(1)
+      record.logical_name = m.group(1)
       flags = []
 
     for f in flags:
       if not f in ('is_smooth', 'is_loading_resources'):
         raise Exception(
           'Unrecognized flag in timeline Interaction record: %s' % f)
-    self.is_smooth = 'is_smooth' in flags
-    self.is_loading_resources = 'is_loading_resources' in flags
+    record.is_smooth = 'is_smooth' in flags
+    record.is_loading_resources = 'is_loading_resources' in flags
+    return record
+
+  @staticmethod
+  def FromBounds(bounds):

[nduca, 2014/03/07 20:05:56]

logical name is required

+    record = TimelineInteractionRecord(bounds.min, bounds.max)
+    return record
 
   def GetResultNameFor(self, result_name):
-    return "%s/%s" % (self.logical_name, result_name)
+    if self.logical_name:
+      return "%s-%s" % (self.logical_name, result_name)
+    else:
+      return result_name