Move smoothness to the new API

tools/perf/metrics/timeline_based_metric.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+
+class _ResultsWrapper(object):

[nduca, 2014/03/07 20:05:56]

this class should be in TimelineBasedMeasurement

+  def __init__(self, results, interaction_record):
+    self._results = results
+    self._interaction_record = interaction_record
+
+  def Add(self, trace_name, units, value, chart_name=None, data_type='default'):
+    trace_name = self._interaction_record.GetResultNameFor(trace_name)
+    self._results.Add(trace_name, units, value, chart_name, data_type)
+
+  def AddSummary(self, trace_name, units, value, chart_name=None,
+                  data_type='default'):
+    trace_name = self._interaction_record.GetResultNameFor(trace_name)
+    self._results.AddSummary(trace_name, units, value, chart_name, data_type)
+
+
+def WrapResults(add_results_func):
+  def WrappedAddResults(self, model, renderer_thread, interaction_record,
+                        results):
+    wrapped_results = _ResultsWrapper(results, interaction_record)
+    return add_results_func(self, model, renderer_thread, interaction_record,
+                      wrapped_results)
+  return WrappedAddResults
+
+
 class TimelineBasedMetric(object):
   def __init__(self):
     """Computes metrics from a telemetry.core.timeline Model and a range
 
     """
     super(TimelineBasedMetric, self).__init__()
 
+  @WrapResults

[nduca, 2014/03/07 20:05:56]

i'd rather that the measurement construct this wrapper just before calling
AddResults no the metric

   def AddResults(self, model, renderer_thread,
                  interaction_record, results):
     """Computes and adds metrics for the interaction_record's time range.
 
     The override of this method should compute results on the data **only**
     within the interaction_record's start and end time.
 
     model is an instance of telemetry.core.timeline.model.TimelineModel.
     interaction_record is an instance of TimelineInteractionRecord.
     results is an instance of page.PageTestResults.
 
     """
     raise NotImplementedError()