Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: tools/perf/measurements/timeline_based_measurement_unittest.py

Issue 170183004: Move smoothness to the new API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@submit
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import os 5 import os
6 import unittest 6 import unittest
7 7
8 from measurements import timeline_based_measurement as tbm_module 8 from measurements import timeline_based_measurement as tbm_module
9 from metrics import timeline_based_metric 9 from metrics import timeline_based_metric
10 from telemetry.core import wpr_modes 10 from telemetry.core import wpr_modes
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 "description": "hello", 83 "description": "hello",
84 "archive_path": "foo.wpr", 84 "archive_path": "foo.wpr",
85 "pages": [ 85 "pages": [
86 {"url": "http://www.bar.com/"} 86 {"url": "http://www.bar.com/"}
87 ] 87 ]
88 }, os.path.dirname(__file__)) 88 }, os.path.dirname(__file__))
89 results.WillMeasurePage(ps.pages[0]) 89 results.WillMeasurePage(ps.pages[0])
90 metric.AddResults(results) 90 metric.AddResults(results)
91 results.DidMeasurePage() 91 results.DidMeasurePage()
92 92
93 v = results.FindAllPageSpecificValuesNamed('LogicalName1/FakeSmoothMetric') 93 v = results.FindAllPageSpecificValuesNamed('LogicalName1-FakeSmoothMetric')
94 self.assertEquals(len(v), 1) 94 self.assertEquals(len(v), 1)
95 v = results.FindAllPageSpecificValuesNamed('LogicalName2/FakeLoadingMetric') 95 v = results.FindAllPageSpecificValuesNamed('LogicalName2-FakeLoadingMetric')
96 self.assertEquals(len(v), 1) 96 self.assertEquals(len(v), 1)
97 97
98 98
99 class TimelineBasedMeasurementTest( 99 class TimelineBasedMeasurementTest(
100 page_measurement_unittest_base.PageMeasurementUnitTestBase): 100 page_measurement_unittest_base.PageMeasurementUnitTestBase):
101 def setUp(self): 101 def setUp(self):
102 self._options = options_for_unittests.GetCopy() 102 self._options = options_for_unittests.GetCopy()
103 self._options.browser_options.wpr_mode = wpr_modes.WPR_OFF 103 self._options.browser_options.wpr_mode = wpr_modes.WPR_OFF
104 104
105 def testTimelineBasedForSmoke(self): 105 def testTimelineBasedForSmoke(self):
106 ps = self.CreatePageSetFromFileInUnittestDataDir( 106 ps = self.CreatePageSetFromFileInUnittestDataDir(
107 'interaction_enabled_page.html') 107 'interaction_enabled_page.html')
108 setattr(ps.pages[0], 'smoothness', {'action': 'wait', 108 setattr(ps.pages[0], 'smoothness', [{'action': 'scroll'},
109 'javascript': 'window.animationDone'}) 109 {'action': 'wait',
110 'javascript': 'window.animationDone'}])
110 measurement = tbm_module.TimelineBasedMeasurement() 111 measurement = tbm_module.TimelineBasedMeasurement()
111 results = self.RunMeasurement(measurement, ps, 112 results = self.RunMeasurement(measurement, ps,
112 options=self._options) 113 options=self._options)
113 self.assertEquals(0, len(results.failures)) 114 self.assertEquals(0, len(results.failures))
115 v = results.FindAllPageSpecificValuesNamed('CenterAnimation-jank')
116 self.assertEquals(len(v), 2)
117 v = results.FindAllPageSpecificValuesNamed('DrawerAnimation-jank')
118 self.assertEquals(len(v), 2)
119
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698