Oilpan: Build fix after r167288

Oilpan: Build fix after r167288

r167288 broke oilpan's build:
http://chromegw.corp.google.com/i/chromium.webkit/builders/WebKit%252520Linux%252520Oilpan/builds/991/steps/compile/logs/stdio#error1

This CL fixes the build by replacing nullptr with 0.

TBR=tkent

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167307

[haraken, 2014-02-18 06:43:49]

Committed patchset #1 manually as r167307 (presubmit successful).

[tkent, 2014-02-18 06:47:38]

lgtm

[philipj_slow, 2014-02-18 07:22:43]

This broke compilation on Mac:

../../third_party/WebKit/Source/core/inspector/InspectorDOMStorageAgent.cpp:204:16:
error: conversion function from 'int' to
'PassOwnPtrWillBeRawPtr<WebCore::StorageArea>' (aka
'WTF::PassOwnPtr<WebCore::StorageArea>') invokes a deleted function
        return 0;
               ^
../../third_party/WebKit/Source/wtf/PassOwnPtr.h:41:45: note: 'PassOwnPtr' has
been explicitly marked deleted here
        WTF_DISALLOW_CONSTRUCTION_FROM_ZERO(PassOwnPtr);
                                            ^
../../third_party/WebKit/Source/wtf/NullPtr.h:59:9: note: expanded from macro
'WTF_DISALLOW_CONSTRUCTION_FROM_ZERO'
        ClassName(int) = delete
        ^
../../third_party/WebKit/Source/core/inspector/InspectorDOMStorageAgent.cpp:211:16:
error: conversion function from 'int' to
'PassOwnPtrWillBeRawPtr<WebCore::StorageArea>' (aka
'WTF::PassOwnPtr<WebCore::StorageArea>') invokes a deleted function
        return 0;
               ^
../../third_party/WebKit/Source/wtf/PassOwnPtr.h:41:45: note: 'PassOwnPtr' has
been explicitly marked deleted here
        WTF_DISALLOW_CONSTRUCTION_FROM_ZERO(PassOwnPtr);
                                            ^
../../third_party/WebKit/Source/wtf/NullPtr.h:59:9: note: expanded from macro
'WTF_DISALLOW_CONSTRUCTION_FROM_ZERO'
        ClassName(int) = delete
        ^

[haraken, 2014-02-18 07:27:17]

On 2014/02/18 07:22:43, philipj wrote:
> This broke compilation on Mac:
> 
>
../../third_party/WebKit/Source/core/inspector/InspectorDOMStorageAgent.cpp:204:16:
> error: conversion function from 'int' to
> 'PassOwnPtrWillBeRawPtr<WebCore::StorageArea>' (aka
> 'WTF::PassOwnPtr<WebCore::StorageArea>') invokes a deleted function
>         return 0;
>                ^
> ../../third_party/WebKit/Source/wtf/PassOwnPtr.h:41:45: note: 'PassOwnPtr' has
> been explicitly marked deleted here
>         WTF_DISALLOW_CONSTRUCTION_FROM_ZERO(PassOwnPtr);
>                                             ^
> ../../third_party/WebKit/Source/wtf/NullPtr.h:59:9: note: expanded from macro
> 'WTF_DISALLOW_CONSTRUCTION_FROM_ZERO'
>         ClassName(int) = delete
>         ^
>
../../third_party/WebKit/Source/core/inspector/InspectorDOMStorageAgent.cpp:211:16:
> error: conversion function from 'int' to
> 'PassOwnPtrWillBeRawPtr<WebCore::StorageArea>' (aka
> 'WTF::PassOwnPtr<WebCore::StorageArea>') invokes a deleted function
>         return 0;
>                ^
> ../../third_party/WebKit/Source/wtf/PassOwnPtr.h:41:45: note: 'PassOwnPtr' has
> been explicitly marked deleted here
>         WTF_DISALLOW_CONSTRUCTION_FROM_ZERO(PassOwnPtr);
>                                             ^
> ../../third_party/WebKit/Source/wtf/NullPtr.h:59:9: note: expanded from macro
> 'WTF_DISALLOW_CONSTRUCTION_FROM_ZERO'
>         ClassName(int) = delete
>         ^

The problem here is that OwnPtr expects nullptr but RawPtr expects 0. So
PassOwnPtrWillBeRawPtr causes the problem whether it returns nullptr or 0.

I think this needs a substantial fix, so let me revert the CLs that caused the
problem.

[haraken, 2014-02-18 07:30:11]

On 2014/02/18 07:27:17, haraken wrote:
> On 2014/02/18 07:22:43, philipj wrote:
> > This broke compilation on Mac:
> > 
> >
>
../../third_party/WebKit/Source/core/inspector/InspectorDOMStorageAgent.cpp:204:16:
> > error: conversion function from 'int' to
> > 'PassOwnPtrWillBeRawPtr<WebCore::StorageArea>' (aka
> > 'WTF::PassOwnPtr<WebCore::StorageArea>') invokes a deleted function
> >         return 0;
> >                ^
> > ../../third_party/WebKit/Source/wtf/PassOwnPtr.h:41:45: note: 'PassOwnPtr'
has
> > been explicitly marked deleted here
> >         WTF_DISALLOW_CONSTRUCTION_FROM_ZERO(PassOwnPtr);
> >                                             ^
> > ../../third_party/WebKit/Source/wtf/NullPtr.h:59:9: note: expanded from
macro
> > 'WTF_DISALLOW_CONSTRUCTION_FROM_ZERO'
> >         ClassName(int) = delete
> >         ^
> >
>
../../third_party/WebKit/Source/core/inspector/InspectorDOMStorageAgent.cpp:211:16:
> > error: conversion function from 'int' to
> > 'PassOwnPtrWillBeRawPtr<WebCore::StorageArea>' (aka
> > 'WTF::PassOwnPtr<WebCore::StorageArea>') invokes a deleted function
> >         return 0;
> >                ^
> > ../../third_party/WebKit/Source/wtf/PassOwnPtr.h:41:45: note: 'PassOwnPtr'
has
> > been explicitly marked deleted here
> >         WTF_DISALLOW_CONSTRUCTION_FROM_ZERO(PassOwnPtr);
> >                                             ^
> > ../../third_party/WebKit/Source/wtf/NullPtr.h:59:9: note: expanded from
macro
> > 'WTF_DISALLOW_CONSTRUCTION_FROM_ZERO'
> >         ClassName(int) = delete
> >         ^
> 
> The problem here is that OwnPtr expects nullptr but RawPtr expects 0. So
> PassOwnPtrWillBeRawPtr causes the problem whether it returns nullptr or 0.
> 
> I think this needs a substantial fix, so let me revert the CLs that caused the
> problem.

Reverted in r167310