third_party/WebKit/Source/core/animation/InvalidatableInterpolation.cpp - Issue 1701813002: Make Keyframe::PropertySpecificKeyframes RefCounted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/InvalidatableInterpolation.cpp

Issue 1701813002: Make Keyframe::PropertySpecificKeyframes RefCounted (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: InvalidatableInterpolation RefPtrs Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h ('k') | third_party/WebKit/Source/core/animation/Keyframe.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/InvalidatableInterpolation.cpp

diff --git a/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.cpp b/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.cpp

index 2f6b019c464261eeed37f17ac3de20733b4f7090..582b40b435929a83694dd123e57a05a16ea45f70 100644

--- a/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.cpp

+++ b/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.cpp

@@ -146,8 +146,8 @@ void InvalidatableInterpolation::setFlagIfInheritUsed(InterpolationEnvironment&

return;

if (!environment.state().parentStyle())

return;

- const CSSValue* startValue = toCSSPropertySpecificKeyframe(m_startKeyframe)->value();

- const CSSValue* endValue = toCSSPropertySpecificKeyframe(m_endKeyframe)->value();

+ const CSSValue* startValue = toCSSPropertySpecificKeyframe(*m_startKeyframe).value();

+ const CSSValue* endValue = toCSSPropertySpecificKeyframe(*m_endKeyframe).value();

if ((startValue && startValue->isInheritedValue())

|| (endValue && endValue->isInheritedValue())) {

environment.state().parentStyle()->setHasExplicitlyInheritedProperties();