Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 170173003: Revert of Re-enable prerender RemovingLink browser tests. (Closed)

Created:
6 years, 10 months ago by Lei Zhang
Modified:
6 years, 10 months ago
Reviewers:
mmenke, davidben
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, davidben+watch_chromium.org
Visibility:
Public.

Description

Revert of Re-enable prerender RemovingLink browser tests. (https://codereview.chromium.org/142013004/) Reason for revert: Failing on XP Tests 1, build 30187 and onwards. Also failing on XP Tests 2 and 3. [ RUN ] PrerenderBrowserTest.PrerenderPageRemovingLinkWithTwoLinks HTTP server started on 127.0.0.1:4080... sending server_data: {"host": "127.0.0.1", "port": 4080} (35 bytes) File not found prerender/prerender_page.html%E2%80%93)%C3%A4%C2%B3%C3%BBh%C3%BE)%C3%ACz%C2%BB full path:E:\b\build\slave\XP_Tests__1_\build\src\chrome/test/data\prerender\prerender_page.html%E2%80%93)%C3%A4%C2%B3%C3%BBh%C3%BE)%C3%ACz%C2%BB 127.0.0.1 - - [14/Feb/2014 22:17:53] code 404, message Not Found [2656:2572:0214/221753:3777828:INFO:CONSOLE(1)] "Uncaught ReferenceError: DidPrerenderPass is not defined", source: (1) Original issue's description: > Re-enable prerender RemovingLink browser tests. > > The tests have changed significantly since they were first disabled. Add a > WaitForStop or two for good measure, but leave them as-is for the most part. > They can be disabled again if they still flake. Merge their custom prerender > loader into the main one; it's mostly the same. > > In addition, for better test coverage, add a new test which asserts on events > received when a <link rel=prerender> is added for an existing prerender after > that prerender has loaded. Significantly rework the prerender events logic > to allow the test framework to wait on an event being received in the loader. > > BUG=167340, 128841 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251495 TBR=mmenke@chromium.org,davidben@chromium.org NOTREECHECKS=true NOTRY=true BUG=167340, 128841 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251732

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -155 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 5 chunks +62 lines, -75 lines 0 comments Download
M chrome/test/data/prerender/prerender_events_common.js View 1 chunk +44 lines, -71 lines 0 comments Download
M chrome/test/data/prerender/prerender_loader.html View 1 chunk +1 line, -5 lines 0 comments Download
A chrome/test/data/prerender/prerender_loader_removing_links.html View 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/test/data/prerender/prerender_page_pending.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/prerender/prerender_page_removes_pending.html View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
Created Revert of Re-enable prerender RemovingLink browser tests.
6 years, 10 months ago (2014-02-18 06:53:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/170173003/1
6 years, 10 months ago (2014-02-18 06:53:36 UTC) #2
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 06:54:04 UTC) #3
Message was sent while issue was closed.
Change committed as 251732

Powered by Google App Engine
This is Rietveld 408576698