Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1701703003: Reland of Cleanup: Remove unused PrintSettings shrink factors. (Closed)

Created:
4 years, 10 months ago by phoglund_chromium
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Cleanup: Remove unused PrintSettings shrink factors. (patchset #1 id:1 of https://codereview.chromium.org/1697183002/ ) Reason for revert: Unreverting since this patch turned out to be innocent. Original issue's description: > Revert of Cleanup: Remove unused PrintSettings shrink factors. (patchset #1 id:1 of https://codereview.chromium.org/1676953003/ ) > > Reason for revert: > Seems to break printing WebKit Linux MSAN (test times out): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/8511 > > Original issue's description: > > Cleanup: Remove unused PrintSettings shrink factors. > > > > - They have been unused for 7 years. > > - The copy that is being used eventually moved to > > third_party/WebKit/Source/core/page/PrintContext.cpp. > > > > Committed: https://crrev.com/5e8544fc5972711c5237e3bcd8c018a0b439f4f1 > > Cr-Commit-Position: refs/heads/master@{#374553} > > TBR=vitalybuka@chromium.org,tsepez@chromium.org,thestig@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. TBR=vitalybuka@chromium.org,tsepez@chromium.org,thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/51040e9fdca3306a57d1c45b637e6290caef5495 Cr-Commit-Position: refs/heads/master@{#375543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -53 lines) Patch
M chrome/test/data/printing/cloud_print_uitest.html View 2 chunks +1 line, -3 lines 0 comments Download
M components/printing/browser/print_manager_utils.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/printing/common/print_messages.h View 2 chunks +0 lines, -8 lines 0 comments Download
M components/printing/common/print_messages.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M components/printing/renderer/print_web_view_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/printing/test/mock_printer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/printing/test/mock_printer.cc View 4 chunks +0 lines, -8 lines 0 comments Download
M printing/print_settings.h View 2 chunks +0 lines, -17 lines 0 comments Download
M printing/print_settings.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M printing/print_settings_conversion.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
phoglund_chromium
Created Reland of Cleanup: Remove unused PrintSettings shrink factors.
4 years, 10 months ago (2016-02-16 10:07:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701703003/1
4 years, 10 months ago (2016-02-16 10:07:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 10:09:01 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:52:03 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51040e9fdca3306a57d1c45b637e6290caef5495
Cr-Commit-Position: refs/heads/master@{#375543}

Powered by Google App Engine
This is Rietveld 408576698