tests/compiler/dart2js/call_site_simple_type_inferer_test.dart - Issue 17017003: Introduce an ElementTypeMask to recognize simple constraints like "the type of parameter foo is the…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/call_site_simple_type_inferer_test.dart

Issue 17017003: Introduce an ElementTypeMask to recognize simple constraints like "the type of parameter foo is the… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/types/union_type_mask.dart ('k') | tests/compiler/dart2js/concrete_type_inference_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/compiler/dart2js/call_site_simple_type_inferer_test.dart

===================================================================

--- tests/compiler/dart2js/call_site_simple_type_inferer_test.dart (revision 24183)

+++ tests/compiler/dart2js/call_site_simple_type_inferer_test.dart (working copy)

@@ -247,14 +247,12 @@

runTest(TEST_7a, (inferrer) => [subclassOfInterceptor(inferrer)]);

runTest(TEST_7b, (inferrer) => [inferrer.dynamicType.nonNullable()]);

- // In the following tests, we can't infer the right types because we

- // have recursive calls with the same parameters. We should build a

- // constraint system for those, to find the types.

- runTest(TEST_8, (inferrer) => [inferrer.dynamicType,

+ runTest(TEST_8, (inferrer) => [inferrer.intType,

subclassOfInterceptor(inferrer),

inferrer.dynamicType.nonNullable()]);

- runTest(TEST_9, (inferrer) => [inferrer.dynamicType, inferrer.dynamicType]);

- runTest(TEST_10, (inferrer) => [inferrer.dynamicType, inferrer.dynamicType]);

+ runTest(TEST_9, (inferrer) => [inferrer.intType, inferrer.intType]);

+ runTest(TEST_10, (inferrer) => [subclassOfInterceptor(inferrer),

+ subclassOfInterceptor(inferrer)]);

runTest(TEST_11, (inferrer) => [subclassOfInterceptor(inferrer),

subclassOfInterceptor(inferrer)]);

@@ -274,7 +272,8 @@

inferrer.boolType,

inferrer.doubleType]);

- runTest(TEST_18, (inferrer) => [inferrer.dynamicType, inferrer.dynamicType]);

+ runTest(TEST_18, (inferrer) => [subclassOfInterceptor(inferrer),

+ subclassOfInterceptor(inferrer)]);

}

void main() {