sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart - Issue 17017003: Introduce an ElementTypeMask to recognize simple constraints like "the type of parameter foo is the…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart

Issue 17017003: Introduce an ElementTypeMask to recognize simple constraints like "the type of parameter foo is the… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/types/forwarding_type_mask.dart ('k') | sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart (revision 24183)

+++ sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart (working copy)

@@ -31,9 +31,9 @@

* Returns the least upper bound between [firstType] and

* [secondType].

- TypeMask computeLUB(TypeMask firstType,

- TypeMask secondType,

- Compiler compiler) {

+TypeMask computeLUB(TypeMask firstType,

+ TypeMask secondType,

+ Compiler compiler) {

TypeMask dynamicType = compiler.typesTask.dynamicType;

if (firstType == null) {

return secondType;

@@ -41,6 +41,8 @@

return secondType;

} else if (firstType == dynamicType) {

return firstType;

+ } else if (firstType == secondType) {

+ return firstType;

} else {

TypeMask union = firstType.union(secondType, compiler);

// TODO(kasperl): If the union isn't nullable it seems wasteful