Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 17017: Experimental: the code to make a frame mergable is sometimes emitted... (Closed)

Created:
11 years, 11 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Experimental: the code to make a frame mergable is sometimes emitted between an instruction that sets the processor flags and an instruction that tests them. The flags must not be affected by the make mergable code (mov and push is OK, xor is not). Committed: http://code.google.com/p/v8/source/detail?r=1022

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/virtual-frame-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
This is annoying and fragile. We probably want to get the cc_reg inside the virtual ...
11 years, 11 months ago (2008-12-30 12:54:29 UTC) #1
William Hesse
11 years, 11 months ago (2008-12-30 13:28:02 UTC) #2
LGTM, but don't we need a long-term fix that does not load immediate 32 bit
constants?

Powered by Google App Engine
This is Rietveld 408576698