Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1257)

Issue 1701673002: [turbofan] Assign better types to various String builtins. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Assign better types to various String builtins. Properly type String.prototype.concat, String.prototype.charCodeAt, and String.prototype.toLowerCase/toUpperCase in TurboFan. Also assign better type to %_StringCharFromCode. R=jarin@chromium.org Committed: https://crrev.com/1d9e9c830b0c358aca53ad4294bb00e2d10e6c0b Cr-Commit-Position: refs/heads/master@{#33991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -31 lines) Patch
M src/compiler/typer.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +34 lines, -31 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-15 10:46:43 UTC) #1
Jarin
lgtm
4 years, 10 months ago (2016-02-15 11:20:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701673002/1
4 years, 10 months ago (2016-02-15 11:20:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-15 11:57:20 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 11:57:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d9e9c830b0c358aca53ad4294bb00e2d10e6c0b
Cr-Commit-Position: refs/heads/master@{#33991}

Powered by Google App Engine
This is Rietveld 408576698