Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 1701653002: Revert of [runtime] Turn ArgumentAccessStub into FastNewSloppyArgumentsStub. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/mips64/full-codegen-mips64.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 if (arguments != NULL) { 261 if (arguments != NULL) {
262 // Arguments object must be allocated after the context object, in 262 // Arguments object must be allocated after the context object, in
263 // case the "arguments" or ".arguments" variables are in the context. 263 // case the "arguments" or ".arguments" variables are in the context.
264 Comment cmnt(masm_, "[ Allocate arguments object"); 264 Comment cmnt(masm_, "[ Allocate arguments object");
265 if (!function_in_register) { 265 if (!function_in_register) {
266 __ movp(rdi, Operand(rbp, JavaScriptFrameConstants::kFunctionOffset)); 266 __ movp(rdi, Operand(rbp, JavaScriptFrameConstants::kFunctionOffset));
267 } 267 }
268 if (is_strict(language_mode()) || !has_simple_parameters()) { 268 if (is_strict(language_mode()) || !has_simple_parameters()) {
269 FastNewStrictArgumentsStub stub(isolate()); 269 FastNewStrictArgumentsStub stub(isolate());
270 __ CallStub(&stub); 270 __ CallStub(&stub);
271 } else if (literal()->has_duplicate_parameters()) {
272 __ Push(rdi);
273 __ CallRuntime(Runtime::kNewSloppyArguments_Generic);
274 } else { 271 } else {
275 FastNewSloppyArgumentsStub stub(isolate()); 272 DCHECK(rdi.is(ArgumentsAccessNewDescriptor::function()));
273 // The receiver is just before the parameters on the caller's stack.
274 int num_parameters = info->scope()->num_parameters();
275 int offset = num_parameters * kPointerSize;
276 __ Move(ArgumentsAccessNewDescriptor::parameter_count(),
277 Smi::FromInt(num_parameters));
278 __ leap(ArgumentsAccessNewDescriptor::parameter_pointer(),
279 Operand(rbp, StandardFrameConstants::kCallerSPOffset + offset));
280
281 // Arguments to ArgumentsAccessStub:
282 // function, parameter pointer, parameter count.
283 // The stub will rewrite parameter pointer and parameter count if the
284 // previous stack frame was an arguments adapter frame.
285 ArgumentsAccessStub::Type type = ArgumentsAccessStub::ComputeType(
286 literal()->has_duplicate_parameters());
287 ArgumentsAccessStub stub(isolate(), type);
276 __ CallStub(&stub); 288 __ CallStub(&stub);
277 } 289 }
278 290
279 SetVar(arguments, rax, rbx, rdx); 291 SetVar(arguments, rax, rbx, rdx);
280 } 292 }
281 293
282 if (FLAG_trace) { 294 if (FLAG_trace) {
283 __ CallRuntime(Runtime::kTraceEnter); 295 __ CallRuntime(Runtime::kTraceEnter);
284 } 296 }
285 297
(...skipping 4221 matching lines...) Expand 10 before | Expand all | Expand 10 after
4507 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 4519 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
4508 Assembler::target_address_at(call_target_address, 4520 Assembler::target_address_at(call_target_address,
4509 unoptimized_code)); 4521 unoptimized_code));
4510 return OSR_AFTER_STACK_CHECK; 4522 return OSR_AFTER_STACK_CHECK;
4511 } 4523 }
4512 4524
4513 } // namespace internal 4525 } // namespace internal
4514 } // namespace v8 4526 } // namespace v8
4515 4527
4516 #endif // V8_TARGET_ARCH_X64 4528 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/full-codegen/mips64/full-codegen-mips64.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698