Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1701653002: Revert of [runtime] Turn ArgumentAccessStub into FastNewSloppyArgumentsStub. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [runtime] Turn ArgumentAccessStub into FastNewSloppyArgumentsStub. (patchset #2 id:20001 of https://codereview.chromium.org/1695633003/ ) Reason for revert: [Sheriff] Breaks ASAN with mipsel compile: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20ASAN%20mipsel%20-%20debug%20builder/builds/4558/ Original issue's description: > [runtime] Turn ArgumentAccessStub into FastNewSloppyArgumentsStub. > > Turn the fast case of ArgumentsAccessStub into a new stub > FastNewSloppyArgumentsStub, which is similar to the existing > FastNewStrictArgumentsStub, although not polished yet, and the slow > case always went to the runtime anyway, so we can just directly emit > a runtime call there. > > R=mstarzinger@chromium.org > > Committed: https://crrev.com/55b0b4f6d572531eec00ab6ebd8f6feb7c584e04 > Cr-Commit-Position: refs/heads/master@{#33973} TBR=mstarzinger@chromium.org,jarin@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/f0561ac5d9a8e5e247329486acaf937514f98ba5 Cr-Commit-Position: refs/heads/master@{#33976}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1743 lines, -1492 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +221 lines, -205 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +301 lines, -282 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M src/code-factory.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/code-factory.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M src/code-stubs.h View 4 chunks +41 lines, -16 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M src/compiler/js-create-lowering.cc View 2 chunks +15 lines, -10 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +16 lines, -4 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +16 lines, -4 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +16 lines, -4 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +16 lines, -4 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +16 lines, -4 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +16 lines, -4 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +262 lines, -241 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M src/interface-descriptors.h View 4 chunks +13 lines, -8 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +230 lines, -218 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 2 chunks +236 lines, -220 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +240 lines, -218 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [runtime] Turn ArgumentAccessStub into FastNewSloppyArgumentsStub.
4 years, 10 months ago (2016-02-15 08:02:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701653002/1
4 years, 10 months ago (2016-02-15 08:02:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-15 08:02:29 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 08:03:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0561ac5d9a8e5e247329486acaf937514f98ba5
Cr-Commit-Position: refs/heads/master@{#33976}

Powered by Google App Engine
This is Rietveld 408576698