Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 170163003: Convert search for most visible page in the document to a binary search. (Closed)

Created:
6 years, 10 months ago by raymes
Modified:
6 years, 10 months ago
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Convert search for most visible page in the document to a binary search. The PDF extension needs to compute the most visible page frequently so we use a binary search. BUG=303491 R=arv@chromium.org, koz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252177

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M chrome/browser/resources/pdf/viewport.js View 1 2 1 chunk +28 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
raymes
6 years, 10 months ago (2014-02-18 06:32:57 UTC) #1
koz (OOO until 15th September)
lgtm https://codereview.chromium.org/170163003/diff/1/chrome/browser/resources/pdf/viewport.js File chrome/browser/resources/pdf/viewport.js (right): https://codereview.chromium.org/170163003/diff/1/chrome/browser/resources/pdf/viewport.js#newcode192 chrome/browser/resources/pdf/viewport.js:192: if (area == 0) nit: Maybe move this ...
6 years, 10 months ago (2014-02-18 07:04:33 UTC) #2
raymes
+arv for OWNERS Note I'll be adding a unittest for this file soon. https://codereview.chromium.org/170163003/diff/1/chrome/browser/resources/pdf/viewport.js File ...
6 years, 10 months ago (2014-02-19 05:39:36 UTC) #3
arv (Not doing code reviews)
LGTM
6 years, 10 months ago (2014-02-19 21:33:36 UTC) #4
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 10 months ago (2014-02-19 23:49:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/170163003/80001
6 years, 10 months ago (2014-02-20 01:20:19 UTC) #6
raymes
6 years, 10 months ago (2014-02-20 04:31:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r252177 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698