[turbofan] Enforce that C calls do not use floating point params.

[turbofan] Enforce that C calls do not use floating point params.

Passing floating point params to/from C has never quite worked correctly,
but we've never enforced the restriction early in the CallDescriptor
creation process because of unittests. Fix unittests to make their own
simple call descriptors and not rely on the C ones.

R=bmeurer@chromium.org
BUG=

Committed: https://crrev.com/e2f3003f2ce6618c4d006e0b9f0861a3868f941f
Cr-Commit-Position: refs/heads/master@{#33993}

[Benedikt Meurer, 2016-02-15 12:45:33]

LGTM with nits.

https://codereview.chromium.org/1701593003/diff/1/src/compiler/c-linkage.cc
File src/compiler/c-linkage.cc (right):

https://codereview.chromium.org/1701593003/diff/1/src/compiler/c-linkage.cc#n...
src/compiler/c-linkage.cc:144: CHECK(rep != MachineRepresentation::kFloat32 &&
Nit: two separate CHECKs instead of combining with &&

https://codereview.chromium.org/1701593003/diff/1/src/compiler/c-linkage.cc#n...
src/compiler/c-linkage.cc:149: CHECK(rep != MachineRepresentation::kFloat32 &&
Nit: two separate CHECKs instead of combining with &&

[titzer, 2016-02-15 13:04:05]

On 2016/02/15 12:45:33, Benedikt Meurer wrote:
> LGTM with nits.
> 
> https://codereview.chromium.org/1701593003/diff/1/src/compiler/c-linkage.cc
> File src/compiler/c-linkage.cc (right):
> 
>
https://codereview.chromium.org/1701593003/diff/1/src/compiler/c-linkage.cc#n...
> src/compiler/c-linkage.cc:144: CHECK(rep != MachineRepresentation::kFloat32 &&
> Nit: two separate CHECKs instead of combining with &&

Done.

>
https://codereview.chromium.org/1701593003/diff/1/src/compiler/c-linkage.cc#n...
> src/compiler/c-linkage.cc:149: CHECK(rep != MachineRepresentation::kFloat32 &&
> Nit: two separate CHECKs instead of combining with &&

Done.

[titzer, 2016-02-15 13:23:47]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-02-15 13:23:47]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1701593003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-02-15 13:23:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1701593003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1701593003/20001

[commit-bot: I haz the power, 2016-02-15 13:25:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-15 13:25:34]

Description was changed from

==========
[turbofan] Enforce that C calls do not use floating point params.

Passing floating point params to/from C has never quite worked correctly,
but we've never enforced the restriction early in the CallDescriptor
creation process because of unittests. Fix unittests to make their own
simple call descriptors and not rely on the C ones.

R=bmeurer@chromium.org
BUG=
==========

to

==========
[turbofan] Enforce that C calls do not use floating point params.

Passing floating point params to/from C has never quite worked correctly,
but we've never enforced the restriction early in the CallDescriptor
creation process because of unittests. Fix unittests to make their own
simple call descriptors and not rely on the C ones.

R=bmeurer@chromium.org
BUG=

Committed: https://crrev.com/e2f3003f2ce6618c4d006e0b9f0861a3868f941f
Cr-Commit-Position: refs/heads/master@{#33993}
==========

[commit-bot: I haz the power, 2016-02-15 13:25:35]

Patchset 2 (id:??) landed as
https://crrev.com/e2f3003f2ce6618c4d006e0b9f0861a3868f941f
Cr-Commit-Position: refs/heads/master@{#33993}