chrome/browser/download/download_request_limiter.h - Issue 1701593002: Replace DidGetUserGesture with DidGetUserInteraction in the download request limiter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_request_limiter.h

Issue 1701593002: Replace DidGetUserGesture with DidGetUserInteraction in the download request limiter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@download-request-limiter

Patch Set: Addressing reviewer comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/download/download_request_limiter.h

diff --git a/chrome/browser/download/download_request_limiter.h b/chrome/browser/download/download_request_limiter.h

index d621851f77010bfa7598e8faff9612af97fba72c..caae103f9bc01e355416227d6a128dfa951a8030 100644

--- a/chrome/browser/download/download_request_limiter.h

+++ b/chrome/browser/download/download_request_limiter.h

@@ -109,9 +109,9 @@ class DownloadRequestLimiter

void DidNavigateMainFrame(

const content::LoadCommittedDetails& details,

const content::FrameNavigateParams& params) override;

- // Invoked when a user gesture occurs (mouse click, enter or space). This

- // may result in invoking Remove on DownloadRequestLimiter.

- void DidGetUserGesture() override;

+ // Invoked when a user gesture occurs (mouse click, mouse scroll, tap, or

+ // key down). This may result in invoking Remove on DownloadRequestLimiter.

+ void DidGetUserInteraction(const blink::WebInputEvent::Type type) override;

void WebContentsDestroyed() override;

// Asks the user if they really want to allow the download.

« no previous file with comments | « no previous file | chrome/browser/download/download_request_limiter.cc » ('j') | no next file with comments »