Issue 1701583003: Introduce _emitParameterReferences to avoid mixing params with param references.

Issue 1701583003: Introduce _emitParameterReferences to avoid mixing params with param references. (Closed)

Created:
4 years, 10 months ago by ochafik

Modified:
4 years, 10 months ago

Reviewers:
vsm, Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+98 lines, -13 lines)			Patch
M	lib/src/codegen/js_codegen.dart	View	10 chunks	+37 lines, -13 lines	0 comments	Download
M	test/codegen/destructuring.dart	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	test/codegen/expect/destructuring.js	View	2 chunks	+41 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

ochafik

Hey guys, I'm preparing a cleanup of Parameter vs. Identifier vs. TypeParameter (https://codereview.chromium.org/1686953005/), but in ...

4 years, 10 months ago (2016-02-15 11:06:41 UTC) #2

ochafik

Committed patchset #1 (id:1) manually as 64595bea1915be946fec436ba6cb28e30414539d (presubmit successful).

4 years, 10 months ago (2016-02-16 14:39:20 UTC) #5

Message was sent while issue was closed.

lgtm