Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 1701583002: Decompose Application Package Apptest a bit more. (Closed)

Created:
4 years, 10 months ago by Ben Goodger (Google)
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Decompose Application Package Apptest a bit more. Pull the package application out of the apptest into a separate application. Rename to "PackageApptest" for simplicity. Don't init base in Mojo applications when run in single-process mode, as this means that apps /must/ be shut down in the same order they were started to avoid crashes. This is not possible. TBR=sky@chromium.org BUG=none Committed: https://crrev.com/8e5f0409acbe1455911499c8af88778eb9c441a8 Cr-Commit-Position: refs/heads/master@{#375406}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -241 lines) Patch
M mojo/shell/BUILD.gn View 3 chunks +33 lines, -12 lines 0 comments Download
D mojo/shell/application_package_apptest.cc View 1 chunk +0 lines, -210 lines 0 comments Download
D mojo/shell/application_package_apptest.mojom View 1 chunk +0 lines, -9 lines 0 comments Download
D mojo/shell/application_package_apptest_app_a_manifest.json View 1 chunk +0 lines, -5 lines 0 comments Download
D mojo/shell/application_package_apptest_app_b_manifest.json View 1 chunk +0 lines, -5 lines 0 comments Download
A mojo/shell/package_apptest.cc View 1 2 1 chunk +84 lines, -0 lines 0 comments Download
A + mojo/shell/package_test.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/shell/package_test_app_a_manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/shell/package_test_app_b_manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A mojo/shell/package_test_package.cc View 1 1 chunk +173 lines, -0 lines 0 comments Download
A mojo/shell/package_test_package_manifest.json View 1 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/shell/public/cpp/lib/application_runner.cc View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701583002/20001
4 years, 10 months ago (2016-02-14 23:41:54 UTC) #2
Ben Goodger (Google)
4 years, 10 months ago (2016-02-14 23:42:08 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/21998)
4 years, 10 months ago (2016-02-15 00:01:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701583002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701583002/40001
4 years, 10 months ago (2016-02-15 00:03:11 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/181050)
4 years, 10 months ago (2016-02-15 01:07:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701583002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701583002/60001
4 years, 10 months ago (2016-02-15 03:07:14 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-15 04:11:54 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:48:44 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8e5f0409acbe1455911499c8af88778eb9c441a8
Cr-Commit-Position: refs/heads/master@{#375406}

Powered by Google App Engine
This is Rietveld 408576698