Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 1701503002: Re-land update Xcode emulation extra plist items for Xcode 7.2 (Closed)

Created:
4 years, 10 months ago by justincohen
Modified:
4 years, 10 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Re-land update Xcode emulation extra plist items for Xcode 7.2 Update Xcode emulation extra plist items for Xcode 7.2 Adds DTCompiler, MinimumOSVersion and DTPlatformBuild. Corrects DTSDKName and DTSDKBuild. Also fixes test/ios/gyptest-archs.py and test/ios/gyptest-per-config-settings.py for Xcode 7. This reverts commit 7d29c3de1f5eb74330b81b78ea116b67f684b23b. BUG=577711 R=thakis@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/b25bbc1f942d75783bf4c236219035beff46453d

Patch Set 1 #

Patch Set 2 : Bump to Xcode version to 0720. #

Patch Set 3 : Remove extra call to self._GetSdkVersionInfoItem #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -46 lines) Patch
M pylib/gyp/xcode_emulation.py View 1 2 1 chunk +18 lines, -6 lines 0 comments Download
M test/ios/app-bundle/TestApp/TestApp-Info.plist View 2 chunks +0 lines, -4 lines 0 comments Download
M test/ios/app-bundle/test-archs.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/ios/app-bundle/test-device.gyp View 3 chunks +38 lines, -8 lines 0 comments Download
M test/ios/gyptest-archs.py View 1 chunk +1 line, -1 line 0 comments Download
M test/ios/gyptest-per-config-settings.py View 1 3 chunks +60 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
justincohen
Patchset #2 shows the diff bumping some checks to 0720 instead of 0700. The API ...
4 years, 10 months ago (2016-02-13 19:13:17 UTC) #3
Nico
Lgtm!
4 years, 10 months ago (2016-02-13 19:55:02 UTC) #4
justincohen
4 years, 10 months ago (2016-02-13 20:25:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
b25bbc1f942d75783bf4c236219035beff46453d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698