Fix name creation scope.

bench/SkLinearBitmapPipelineBench.cpp

 /*
  * Copyright 2016 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include <memory>
 #include "SkColor.h"
 #include "SkLinearBitmapPipeline.h"
@@ skipping 29 matching lines @@
             case SkShader::kMirror_TileMode:
                 name.append("Mirror");
                 return name;
             default:
                 name.append("Unknown");
                 return name;
         }
     }
 
     const char* onGetName() override {
-        SkString name {"SkBitmapFP"};
+        fName.set("SkBitmapFP");
         if (fM.getType() & SkMatrix::kPerspective_Mask) {
-            name.append("Perspective");
+            fName.append("Perspective");
         } else if (fM.getType() & SkMatrix::kAffine_Mask) {
-            name.append("Affine");
+            fName.append("Affine");
         } else if (fM.getType() & SkMatrix::kScale_Mask) {
-            name.append("Scale");
+            fName.append("Scale");
         } else if (fM.getType() & SkMatrix::kTranslate_Mask) {
-            name.append("Translate");
+            fName.append("Translate");
         } else {
-            name.append("Identity");
+            fName.append("Identity");
         }
 
-        name.append(tileName("X", fXTile));
-        name.append(tileName("Y", fYTile));
+        fName.append(tileName("X", fXTile));
+        fName.append(tileName("Y", fYTile));
 
         if (fUseBilerp) {
-            name.append("Filter");
+            fName.append("Filter");
         } else {
-            name.append("Nearest");
+            fName.append("Nearest");
         }
 
-        name.appendf("%s", BaseName().c_str());
+        fName.appendf("%s", BaseName().c_str());
 
-        return name.c_str();
+        return fName.c_str();
     }
 
     void onPreDraw(SkCanvas*) override {
         int width = fSrcSize.fWidth;
         int height = fSrcSize.fHeight;
         fBitmap.reset(new uint32_t[width * height]);
         for (int y = 0; y < height; y++) {
             for (int x = 0; x < width; x++) {
                 fBitmap[y * width + x] = (y << 8) + x + (128<<24);
             }
         }
 
         bool trash = fM.invert(&fInvert);
         sk_ignore_unused_variable(trash);
 
         fInfo = SkImageInfo::MakeN32Premul(width, height, fColorProfile);
     }
 
     bool isSuitableFor(Backend backend) override {
         return backend == kNonRendering_Backend;
     }
 
     virtual SkString BaseName() = 0;
 
+    SkString fName;
     SkISize fSrcSize;
     SkColorProfileType fColorProfile;
     SkMatrix fM;
     SkMatrix fInvert;
     bool fUseBilerp;
     SkShader::TileMode fXTile;
     SkShader::TileMode fYTile;
     SkImageInfo fInfo;
     std::unique_ptr<uint32_t[]> fBitmap;
 };
 
 struct SkBitmapFPGeneral final : public CommonBitmapFPBenchmark {
     SkBitmapFPGeneral(
         SkISize srcSize,
         SkColorProfileType colorProfile,
         SkMatrix m,
         bool useBilerp,
         SkShader::TileMode xTile,
         SkShader::TileMode yTile)
             : CommonBitmapFPBenchmark(srcSize, colorProfile, m, useBilerp, xTile, yTile) { }
+
     SkString BaseName() override {
         SkString name;
         if (fInfo.isSRGB()) {
             name.set("sRGB");
         } else {
             name.set("Linr");
         }
         return name;
     }
 
@@ skipping 18 matching lines @@
 
 struct SkBitmapFPOrigShader : public CommonBitmapFPBenchmark {
     SkBitmapFPOrigShader(
         SkISize srcSize,
         SkColorProfileType colorProfile,
         SkMatrix m,
         bool useBilerp,
         SkShader::TileMode xTile,
         SkShader::TileMode yTile)
             : CommonBitmapFPBenchmark(srcSize, colorProfile, m, useBilerp, xTile, yTile) { }
+
     SkString BaseName() override {
         SkString name{"Orig"};
         return name;
     }
 
     void onPreDraw(SkCanvas* c) override {
         CommonBitmapFPBenchmark::onPreDraw(c);
 
         SkImage* image = SkImage::NewRasterCopy(
             fInfo, fBitmap.get(), sizeof(SkPMColor) * fSrcSize.fWidth);
         fImage.reset(image);
         SkShader* shader = fImage->newShader(fXTile, fYTile);
         if (fUseBilerp) {
             fPaint.setFilterQuality(SkFilterQuality::kLow_SkFilterQuality);
         } else {
             fPaint.setFilterQuality(SkFilterQuality::kNone_SkFilterQuality);
         }
         fPaint.setShader(shader)->unref();
-
     }
 
     void onPostDraw(SkCanvas*) override {
 
     }
 
     void onDraw(int loops, SkCanvas*) override {
         int width = fSrcSize.fWidth;
         int height = fSrcSize.fHeight;
 
@@ skipping 93 matching lines @@
     SkShader::kClamp_TileMode, SkShader::kClamp_TileMode);)
 
 DEF_BENCH(return new SkBitmapFPGeneral(
     srcSize, kLinear_SkColorProfileType, mR, true,
     SkShader::kClamp_TileMode, SkShader::kClamp_TileMode);)
 
 DEF_BENCH(return new SkBitmapFPOrigShader(
     srcSize, kLinear_SkColorProfileType, mR, true,
     SkShader::kClamp_TileMode, SkShader::kClamp_TileMode);)