VM service fixes for noopt/precompiled.

VM service fixes for noopt/precompiled.

R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/0c86f0d58b1ebf0917755d5bcc58b27b209939c2

[rmacnak, 2016-02-17 19:06:18]

rmacnak@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-02-17 19:13:08]

LGTM with a question

https://codereview.chromium.org/1701383002/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/1701383002/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:2424: "Cannot get source report when running a precompiled
program.");
We only compile if "forceCompile" is set to true. Maybe check if some parts of a
source report can work without compilation.

[rmacnak, 2016-02-17 22:05:13]

On 2016/02/17 19:13:08, Cutch wrote:
> LGTM with a question
> 
> https://codereview.chromium.org/1701383002/diff/1/runtime/vm/service.cc
> File runtime/vm/service.cc (right):
> 
>
https://codereview.chromium.org/1701383002/diff/1/runtime/vm/service.cc#newco...
> runtime/vm/service.cc:2424: "Cannot get source report when running a
precompiled
> program.");
> We only compile if "forceCompile" is set to true. Maybe check if some parts of
a
> source report can work without compilation.

No, precompiled is also missing the token stream.

[rmacnak, 2016-02-17 22:06:27]

Description was changed from

==========
VM service fixes for noopt/precompiled.
==========

to

==========
VM service fixes for noopt/precompiled.

R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0c86f0d58b1ebf0917755d5bcc58b27b209939c2
==========

[rmacnak, 2016-02-17 22:06:29]

Committed patchset #1 (id:1) manually as
0c86f0d58b1ebf0917755d5bcc58b27b209939c2 (presubmit successful).