Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: xfa/src/fxfa/src/fm2js/xfa_fmparse.h

Issue 1701363003: Fix some issues with CXFA_FMParse/CXFA_FMLexer infinite looping. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: delete more stuff Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | xfa/src/fxfa/src/fm2js/xfa_fmparse.cpp » ('j') | xfa/src/fxfa/src/fm2js/xfa_fmparse.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/src/fxfa/src/fm2js/xfa_fmparse.h
diff --git a/xfa/src/fxfa/src/fm2js/xfa_fmparse.h b/xfa/src/fxfa/src/fm2js/xfa_fmparse.h
index 45cd3db647116e8b0432e136911f31e1aff4d52e..d73d79d12821de63a075f1d77de6040dca3c0370 100644
--- a/xfa/src/fxfa/src/fm2js/xfa_fmparse.h
+++ b/xfa/src/fxfa/src/fm2js/xfa_fmparse.h
@@ -6,10 +6,12 @@
#ifndef _XFA_FM_PARSE_H
#define _XFA_FM_PARSE_H
+
+#include <memory>
+
class CXFA_FMParse {
public:
CXFA_FMParse();
- ~CXFA_FMParse();
int32_t Init(const CFX_WideStringC& wsFormcalc, CXFA_FMErrorInfo* pErrorInfo);
void NextToken();
void Check(XFA_FM_TOKEN op);
@@ -40,10 +42,9 @@ class CXFA_FMParse {
CXFA_FMSimpleExpression* ParseIndexExpression();
private:
- const FX_WCHAR* m_pScript;
- FX_STRSIZE m_uLength;
- CXFA_FMLexer* m_lexer;
+ std::unique_ptr<CXFA_FMLexer> m_lexer;
Tom Sepez 2016/02/18 00:39:14 IWYU for CXFA_FMLexer?
Oliver Chang 2016/02/18 00:49:02 Done.
CXFA_FMToken* m_pToken;
CXFA_FMErrorInfo* m_pErrorInfo;
};
+
#endif
« no previous file with comments | « no previous file | xfa/src/fxfa/src/fm2js/xfa_fmparse.cpp » ('j') | xfa/src/fxfa/src/fm2js/xfa_fmparse.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698