Fix some issues with CXFA_FMParse/CXFA_FMLexer infinite looping.

Fix some issues with CXFA_FMParse/CXFA_FMLexer infinite looping.

The parser did not expect an invalid token in some places, leading to an
infinite loop.

In the lexer, if an invalid string was found, the underlying pointer was
never advanced.

Also cleans some minor stuff along the way:
- Remove nonsensical/useless destructors
- Use unique_ptrs for owned members
- Remove unused members
- Other minor style changes

BUG=587620
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/1e1d3b0f2bc6b6c185b37e0aa6b8663e901dc8bf

[Oliver Chang, 2016-02-18 00:02:29]

Description was changed from

==========
Fix some issues with CXFA_FMParse/CXFA_FMLexer infinite looping.

The parser did not expect an invalid token in some places, leading to an
infinite loop.

In the lexer, if an invalid string was found, the underlying pointer was
never advanced.

Also cleans some minor stuff along the way:
- Remove nonsensical/useless destructors
- Use unique_ptrs for owned members
- Remove unused members
- Other minor style changes

BUG=587620
R=thestig@chromium.org
==========

to

==========
Fix some issues with CXFA_FMParse/CXFA_FMLexer infinite looping.

The parser did not expect an invalid token in some places, leading to an
infinite loop.

In the lexer, if an invalid string was found, the underlying pointer was
never advanced.

Also cleans some minor stuff along the way:
- Remove nonsensical/useless destructors
- Use unique_ptrs for owned members
- Remove unused members
- Other minor style changes

BUG=587620
R=tsepez@chromium.org
==========

[Oliver Chang, 2016-02-18 00:02:29]

ochang@chromium.org changed reviewers:
+ tsepez@chromium.org
- thestig@chromium.org

[Oliver Chang, 2016-02-18 00:04:38]

Tom, please take a look.

There's a lot more cleanup that can be done, but I'll leave those for future
CLs.

[Tom Sepez, 2016-02-18 00:39:15]

lgtm

https://codereview.chromium.org/1701363003/diff/20001/xfa/src/fxfa/src/fm2js/...
File xfa/src/fxfa/src/fm2js/xfa_fmparse.cpp (right):

https://codereview.chromium.org/1701363003/diff/20001/xfa/src/fxfa/src/fm2js/...
xfa/src/fxfa/src/fm2js/xfa_fmparse.cpp:50: if (m_pToken->m_type == TOKeof) {
nit: combine with || while you're at it.

https://codereview.chromium.org/1701363003/diff/20001/xfa/src/fxfa/src/fm2js/...
File xfa/src/fxfa/src/fm2js/xfa_fmparse.h (right):

https://codereview.chromium.org/1701363003/diff/20001/xfa/src/fxfa/src/fm2js/...
xfa/src/fxfa/src/fm2js/xfa_fmparse.h:45: std::unique_ptr<CXFA_FMLexer> m_lexer;
IWYU for CXFA_FMLexer?

https://codereview.chromium.org/1701363003/diff/20001/xfa/src/fxfa/src/fm2js/...
File xfa/src/fxfa/src/fm2js/xfa_lexer.cpp (right):

https://codereview.chromium.org/1701363003/diff/20001/xfa/src/fxfa/src/fm2js/...
xfa/src/fxfa/src/fm2js/xfa_lexer.cpp:82: } else {
nit: else after return. Or just make a boolean expression as in
return (ch != 0 && ..

https://codereview.chromium.org/1701363003/diff/20001/xfa/src/fxfa/src/fm2js/...
File xfa/src/fxfa/src/fm2js/xfa_lexer.h (right):

https://codereview.chromium.org/1701363003/diff/20001/xfa/src/fxfa/src/fm2js/...
xfa/src/fxfa/src/fm2js/xfa_lexer.h:94: CXFA_FMToken(FX_DWORD uLineNum);
nit: explicit

https://codereview.chromium.org/1701363003/diff/20001/xfa/src/fxfa/src/fm2js/...
xfa/src/fxfa/src/fm2js/xfa_lexer.h:96: XFA_FM_TOKEN m_type;
nit: maybe blank line between methods and members, also below.

[Oliver Chang, 2016-02-18 00:49:02]

thanks for the review!

https://codereview.chromium.org/1701363003/diff/20001/xfa/src/fxfa/src/fm2js/...
File xfa/src/fxfa/src/fm2js/xfa_fmparse.cpp (right):

https://codereview.chromium.org/1701363003/diff/20001/xfa/src/fxfa/src/fm2js/...
xfa/src/fxfa/src/fm2js/xfa_fmparse.cpp:50: if (m_pToken->m_type == TOKeof) {
On 2016/02/18 00:39:14, Tom Sepez wrote:
> nit: combine with || while you're at it.

Done.

https://codereview.chromium.org/1701363003/diff/20001/xfa/src/fxfa/src/fm2js/...
File xfa/src/fxfa/src/fm2js/xfa_fmparse.h (right):

https://codereview.chromium.org/1701363003/diff/20001/xfa/src/fxfa/src/fm2js/...
xfa/src/fxfa/src/fm2js/xfa_fmparse.h:45: std::unique_ptr<CXFA_FMLexer> m_lexer;
On 2016/02/18 00:39:14, Tom Sepez wrote:
> IWYU for CXFA_FMLexer?

Done.

https://codereview.chromium.org/1701363003/diff/20001/xfa/src/fxfa/src/fm2js/...
File xfa/src/fxfa/src/fm2js/xfa_lexer.cpp (right):

https://codereview.chromium.org/1701363003/diff/20001/xfa/src/fxfa/src/fm2js/...
xfa/src/fxfa/src/fm2js/xfa_lexer.cpp:82: } else {
On 2016/02/18 00:39:14, Tom Sepez wrote:
> nit: else after return. Or just make a boolean expression as in
> return (ch != 0 && .. 

Done. removed the else.

https://codereview.chromium.org/1701363003/diff/20001/xfa/src/fxfa/src/fm2js/...
File xfa/src/fxfa/src/fm2js/xfa_lexer.h (right):

https://codereview.chromium.org/1701363003/diff/20001/xfa/src/fxfa/src/fm2js/...
xfa/src/fxfa/src/fm2js/xfa_lexer.h:94: CXFA_FMToken(FX_DWORD uLineNum);
On 2016/02/18 00:39:14, Tom Sepez wrote:
> nit: explicit

Done.

https://codereview.chromium.org/1701363003/diff/20001/xfa/src/fxfa/src/fm2js/...
xfa/src/fxfa/src/fm2js/xfa_lexer.h:96: XFA_FM_TOKEN m_type;
On 2016/02/18 00:39:14, Tom Sepez wrote:
> nit: maybe blank line between methods and members, also below.

Done.

[Oliver Chang, 2016-02-18 00:51:58]

Description was changed from

==========
Fix some issues with CXFA_FMParse/CXFA_FMLexer infinite looping.

The parser did not expect an invalid token in some places, leading to an
infinite loop.

In the lexer, if an invalid string was found, the underlying pointer was
never advanced.

Also cleans some minor stuff along the way:
- Remove nonsensical/useless destructors
- Use unique_ptrs for owned members
- Remove unused members
- Other minor style changes

BUG=587620
R=tsepez@chromium.org
==========

to

==========
Fix some issues with CXFA_FMParse/CXFA_FMLexer infinite looping.

The parser did not expect an invalid token in some places, leading to an
infinite loop.

In the lexer, if an invalid string was found, the underlying pointer was
never advanced.

Also cleans some minor stuff along the way:
- Remove nonsensical/useless destructors
- Use unique_ptrs for owned members
- Remove unused members
- Other minor style changes

BUG=587620
R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/1e1d3b0f2bc6b6c185b37e0aa6b8663e901d...
==========

[Oliver Chang, 2016-02-18 00:51:59]

Committed patchset #3 (id:40001) manually as
1e1d3b0f2bc6b6c185b37e0aa6b8663e901dc8bf (presubmit successful).