Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1701363002: Change the account chooser on Win to look like in the mocks. (Closed)

Created:
4 years, 10 months ago by vasilii
Modified:
4 years, 10 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the account chooser on Win to look like in the mocks. BUG=550922 Committed: https://crrev.com/10284b9e09824f6e8ae5437808dbdbdc9cdabea4 Cr-Commit-Position: refs/heads/master@{#376130}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -31 lines) Patch
M chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/passwords/password_dialog_prompts.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc View 4 chunks +25 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/passwords/credentials_item_view.h View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/passwords/credentials_item_view.cc View 5 chunks +24 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
vasilii
Hi Vaclav, please review the CL.
4 years, 10 months ago (2016-02-17 18:27:06 UTC) #2
vabr (Chromium)
Thanks, Vasilii. The code LGTM, I trust you that the result indeed looks like the ...
4 years, 10 months ago (2016-02-18 08:42:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701363002/1
4 years, 10 months ago (2016-02-18 09:40:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 09:45:48 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 09:47:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10284b9e09824f6e8ae5437808dbdbdc9cdabea4
Cr-Commit-Position: refs/heads/master@{#376130}

Powered by Google App Engine
This is Rietveld 408576698