Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Unified Diff: base/task_scheduler/scheduler_thread_pool_impl_unittest.cc

Issue 1701343003: TaskScheduler [13] TaskSchedulerImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@s_6_threadpool
Patch Set: initial patch for review Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/scheduler_thread_pool_impl_unittest.cc
diff --git a/base/task_scheduler/scheduler_thread_pool_impl_unittest.cc b/base/task_scheduler/scheduler_thread_pool_impl_unittest.cc
index 691d0dde959cad136b4220ba8333b31f52b09f18..204e8aaf3a081163ce12b987fe9e9bc40fde190c 100644
--- a/base/task_scheduler/scheduler_thread_pool_impl_unittest.cc
+++ b/base/task_scheduler/scheduler_thread_pool_impl_unittest.cc
@@ -12,6 +12,7 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
+#include "base/callback.h"
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/memory/ref_counted.h"
@@ -126,7 +127,7 @@ class ThreadPostingTasks : public SimpleThread {
WaitBeforePostTask::WAIT_FOR_ALL_THREADS_IDLE) {
thread_pool_->WaitForAllWorkerThreadsIdleForTesting();
}
- EXPECT_TRUE(factory_.PostTask(post_nested_task_, nullptr));
+ EXPECT_TRUE(factory_.PostTask(post_nested_task_, Closure()));
}
}
@@ -228,8 +229,8 @@ TEST_P(TaskSchedulerThreadPoolImplTest, PostTasksWithOneAvailableThread) {
blocked_task_factories.push_back(WrapUnique(new test::TestTaskFactory(
thread_pool_->CreateTaskRunnerWithTraits(TaskTraits(), GetParam()),
GetParam())));
- EXPECT_TRUE(
- blocked_task_factories.back()->PostTask(PostNestedTask::NO, &event));
+ EXPECT_TRUE(blocked_task_factories.back()->PostTask(
+ PostNestedTask::NO, Bind(&WaitableEvent::Wait, Unretained(&event))));
blocked_task_factories.back()->WaitForAllTasksToRun();
}
@@ -239,7 +240,7 @@ TEST_P(TaskSchedulerThreadPoolImplTest, PostTasksWithOneAvailableThread) {
thread_pool_->CreateTaskRunnerWithTraits(TaskTraits(), GetParam()),
GetParam());
for (size_t i = 0; i < kNumTasksPostedPerThread; ++i)
- EXPECT_TRUE(short_task_factory.PostTask(PostNestedTask::NO, nullptr));
+ EXPECT_TRUE(short_task_factory.PostTask(PostNestedTask::NO, Closure()));
short_task_factory.WaitForAllTasksToRun();
// Release tasks waiting on |event|.
@@ -261,7 +262,8 @@ TEST_P(TaskSchedulerThreadPoolImplTest, Saturate) {
factories.push_back(WrapUnique(new test::TestTaskFactory(
thread_pool_->CreateTaskRunnerWithTraits(TaskTraits(), GetParam()),
GetParam())));
- EXPECT_TRUE(factories.back()->PostTask(PostNestedTask::NO, &event));
+ EXPECT_TRUE(factories.back()->PostTask(
+ PostNestedTask::NO, Bind(&WaitableEvent::Wait, Unretained(&event))));
factories.back()->WaitForAllTasksToRun();
}

Powered by Google App Engine
This is Rietveld 408576698