Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3711)

Unified Diff: base/task_scheduler/task_scheduler_impl.cc

Issue 1701343003: TaskScheduler [13] TaskSchedulerImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@s_6_threadpool
Patch Set: self review Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/task_scheduler_impl.cc
diff --git a/base/task_scheduler/task_scheduler_impl.cc b/base/task_scheduler/task_scheduler_impl.cc
new file mode 100644
index 0000000000000000000000000000000000000000..20f567847810d75d1b43ddc5c4f9dc16306e951c
--- /dev/null
+++ b/base/task_scheduler/task_scheduler_impl.cc
@@ -0,0 +1,124 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/task_scheduler/task_scheduler_impl.h"
+
+#include <utility>
+
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/task_scheduler/sequence_sort_key.h"
+
+namespace base {
+namespace internal {
+
+TaskSchedulerImpl::TaskSchedulerImpl()
+ // TODO(robliao): Wake up the service thread instead of calling DoNothing()
+ // when the delayed run time changes.
+ : delayed_task_manager_(Bind(&DoNothing))
+#if DCHECK_IS_ON()
+ ,
+ join_for_testing_returned_(true, false)
+#endif
+{
+ Initialize();
+}
+
+TaskSchedulerImpl::~TaskSchedulerImpl() {
+#if DCHECK_IS_ON()
+ // This is surrounded by DCHECK_IS_ON() to avoid referencing
+ // |join_for_testing_returned_| in non-DCHECK builds.
+ DCHECK(join_for_testing_returned_.IsSignaled());
gab 2016/04/28 19:29:02 DLOG_ASSERT?! :-)
fdoray 2016/04/28 21:02:24 Done.
+#endif
+}
+
+scoped_refptr<TaskRunner> TaskSchedulerImpl::CreateTaskRunnerWithTraits(
+ const TaskTraits& traits,
+ ExecutionMode execution_mode) {
+ return GetThreadPoolForTraits(traits)->CreateTaskRunnerWithTraits(
+ traits, execution_mode);
+}
+
+void TaskSchedulerImpl::Shutdown() {
+ // TODO(fdoray): Increase the priority of BACKGROUND tasks blocking shutdown.
+ task_tracker_.Shutdown();
+}
+
+void TaskSchedulerImpl::JoinForTesting() {
+#if DCHECK_IS_ON()
+ DCHECK(!join_for_testing_returned_.IsSignaled());
+#endif
+ background_thread_pool_->JoinForTesting();
+ background_file_io_thread_pool_->JoinForTesting();
+ normal_thread_pool_->JoinForTesting();
+ normal_file_io_thread_pool_->JoinForTesting();
+#if DCHECK_IS_ON()
+ join_for_testing_returned_.Signal();
+#endif
+}
+
+void TaskSchedulerImpl::Initialize() {
+ using IORestriction = SchedulerThreadPoolImpl::IORestriction;
+
+ const SchedulerThreadPoolImpl::ReEnqueueSequenceCallback
+ re_enqueue_sequence_callback =
+ Bind(&TaskSchedulerImpl::ReEnqueueSequenceCallback, Unretained(this));
+
+ // TODO(fdoray): Derive the number of threads per pool from hardware
+ // characteristics rather than using hard-coded constants.
+
+ // Passing pointers to objects owned by |this| to
+ // SchedulerThreadPoolImpl::Create() is safe because a TaskSchedulerImpl can't
+ // be deleted before all its thread pools have been joined.
+ background_thread_pool_ = SchedulerThreadPoolImpl::Create(
+ ThreadPriority::BACKGROUND, 1U, IORestriction::IO_DISALLOWED,
+ re_enqueue_sequence_callback, &task_tracker_, &delayed_task_manager_);
+ CHECK(background_thread_pool_);
+
+ background_file_io_thread_pool_ = SchedulerThreadPoolImpl::Create(
+ ThreadPriority::BACKGROUND, 1U, IORestriction::IO_ALLOWED,
+ re_enqueue_sequence_callback, &task_tracker_, &delayed_task_manager_);
+ CHECK(background_file_io_thread_pool_);
+
+ normal_thread_pool_ = SchedulerThreadPoolImpl::Create(
+ ThreadPriority::NORMAL, 4U, IORestriction::IO_DISALLOWED,
+ re_enqueue_sequence_callback, &task_tracker_, &delayed_task_manager_);
+ CHECK(normal_thread_pool_);
+
+ normal_file_io_thread_pool_ = SchedulerThreadPoolImpl::Create(
+ ThreadPriority::NORMAL, 12U, IORestriction::IO_ALLOWED,
+ re_enqueue_sequence_callback, &task_tracker_, &delayed_task_manager_);
+ CHECK(normal_file_io_thread_pool_);
+}
+
+SchedulerThreadPool* TaskSchedulerImpl::GetThreadPoolForTraits(
+ const TaskTraits& traits) {
+ if (traits.with_file_io()) {
+ if (traits.priority() == TaskPriority::BACKGROUND)
+ return background_file_io_thread_pool_.get();
+ return normal_file_io_thread_pool_.get();
+ }
+
+ if (traits.priority() == TaskPriority::BACKGROUND)
+ return background_thread_pool_.get();
+ return normal_thread_pool_.get();
+}
+
+void TaskSchedulerImpl::ReEnqueueSequenceCallback(
+ scoped_refptr<Sequence> sequence) {
+ DCHECK(sequence);
+
+ const SequenceSortKey sort_key = sequence->GetSortKey();
+ TaskTraits traits(sequence->PeekTask()->traits);
+
+ // Update the priority of |traits| so that the next task in |sequence| runs
+ // with the highest priority in |sequence|.
gab 2016/04/28 19:29:02 s/./as opposed to the next task's specific priorit
fdoray 2016/04/28 21:02:24 Done.
+ traits.WithPriority(sort_key.priority);
+
+ GetThreadPoolForTraits(traits)->ReEnqueueSequence(std::move(sequence),
+ sort_key);
+}
+
+} // namespace internal
+} // namespace base

Powered by Google App Engine
This is Rietveld 408576698