Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1701323003: Add the beginnings of scripts to produce SDKs. (Closed)

Created:
4 years, 10 months ago by viettrungluu
Modified:
4 years, 10 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, --1 lines) Patch
A sdk_build/README.md View 1 chunk +4 lines, -0 lines 0 comments Download
A sdk_build/build_sdk.py View 1 chunk +80 lines, -0 lines 0 comments Download
A sdk_build/data/cpp/cpp.sdk View 1 chunk +20 lines, -0 lines 2 comments Download
A + sdk_build/pylib/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A sdk_build/pylib/errors.py View 1 chunk +15 lines, -0 lines 0 comments Download
A sdk_build/pylib/git.py View 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
viettrungluu
4 years, 10 months ago (2016-02-17 20:45:07 UTC) #1
vardhan
lgtm https://codereview.chromium.org/1701323003/diff/1/sdk_build/data/cpp/cpp.sdk File sdk_build/data/cpp/cpp.sdk (right): https://codereview.chromium.org/1701323003/diff/1/sdk_build/data/cpp/cpp.sdk#newcode6 sdk_build/data/cpp/cpp.sdk:6: # //mojo/sdk_build/build_sdk.py. should you mention that this spec ...
4 years, 10 months ago (2016-02-17 21:10:44 UTC) #2
viettrungluu
Thanks. https://codereview.chromium.org/1701323003/diff/1/sdk_build/data/cpp/cpp.sdk File sdk_build/data/cpp/cpp.sdk (right): https://codereview.chromium.org/1701323003/diff/1/sdk_build/data/cpp/cpp.sdk#newcode6 sdk_build/data/cpp/cpp.sdk:6: # //mojo/sdk_build/build_sdk.py. On 2016/02/17 21:10:44, vardhan wrote: > ...
4 years, 10 months ago (2016-02-17 21:28:55 UTC) #3
viettrungluu
4 years, 10 months ago (2016-02-17 21:29:17 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a0bce06ddee3b110028cb7be75a46a3f062af57f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698