third_party/WebKit/Source/modules/push_messaging/PushManager.idl - Issue 1701313002: Partial implementation of subscription restrictions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushManager.idl

Issue 1701313002: Partial implementation of subscription restrictions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added exception failure return and updated more tests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/push_messaging/PushManager.cpp ('K') | « third_party/WebKit/Source/modules/push_messaging/PushManager.cpp ('k') | third_party/WebKit/Source/modules/push_messaging/PushManagerTest.cpp » ('j') | third_party/WebKit/Source/modules/push_messaging/PushManagerTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/PushManager.idl

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushManager.idl b/third_party/WebKit/Source/modules/push_messaging/PushManager.idl

index ddb613921d1989001a83a466f87a3a389e568f74..0c4ff8641033a34473d5629424e84df507ca6239 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushManager.idl

+++ b/third_party/WebKit/Source/modules/push_messaging/PushManager.idl

@@ -9,7 +9,7 @@

GarbageCollected,

RuntimeEnabled=PushMessaging,

] interface PushManager {

- [CallWith=ScriptState] Promise<PushSubscription> subscribe(optional PushSubscriptionOptions options);

+ [CallWith=ScriptState, RaisesException] Promise<PushSubscription> subscribe(optional PushSubscriptionOptions options);

[CallWith=ScriptState] Promise<PushSubscription?> getSubscription();

- [CallWith=ScriptState] Promise permissionState(optional PushSubscriptionOptions options);

+ [CallWith=ScriptState, RaisesException] Promise permissionState(optional PushSubscriptionOptions options);

};