Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1434)

Unified Diff: content/renderer/push_messaging/push_messaging_dispatcher.h

Issue 1701313002: Partial implementation of subscription restrictions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added testing and integrated previous comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/push_messaging/push_messaging_dispatcher.h
diff --git a/content/renderer/push_messaging/push_messaging_dispatcher.h b/content/renderer/push_messaging/push_messaging_dispatcher.h
index ca6610b0f3ddb9ac7385586b62552fbfedef3157..71294e22d0da98cfc0a60accf21dcb4de7bd4950 100644
--- a/content/renderer/push_messaging/push_messaging_dispatcher.h
+++ b/content/renderer/push_messaging/push_messaging_dispatcher.h
@@ -29,6 +29,7 @@ class Message;
namespace content {
struct Manifest;
+struct PushSubscriptionOptions;
class PushMessagingDispatcher : public RenderFrameObserver,
public blink::WebPushClient {
@@ -46,12 +47,17 @@ class PushMessagingDispatcher : public RenderFrameObserver,
const blink::WebPushSubscriptionOptions& options,
blink::WebPushSubscriptionCallbacks* callbacks) override;
- void DoSubscribe(
+ void DidGetManifest(
blink::WebServiceWorkerRegistration* service_worker_registration,
const blink::WebPushSubscriptionOptions& options,
blink::WebPushSubscriptionCallbacks* callbacks,
const Manifest& manifest);
+ void DoSubscribe(
+ blink::WebServiceWorkerRegistration* service_worker_registration,
+ const PushSubscriptionOptions& options,
+ blink::WebPushSubscriptionCallbacks* callbacks);
+
void OnSubscribeFromDocumentSuccess(int32_t request_id,
const GURL& endpoint,
const std::vector<uint8_t>& p256dh,

Powered by Google App Engine
This is Rietveld 408576698