chrome/browser/push_messaging/push_messaging_service_unittest.cc - Issue 1701313002: Partial implementation of subscription restrictions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_service_unittest.cc

Issue 1701313002: Partial implementation of subscription restrictions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added testing and integrated previous comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/push_messaging/push_messaging_service_impl.cc ('k') | chrome/test/data/push_messaging/push_test.js » ('j') | chrome/test/data/push_messaging/push_test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/push_messaging/push_messaging_service_unittest.cc

diff --git a/chrome/browser/push_messaging/push_messaging_service_unittest.cc b/chrome/browser/push_messaging/push_messaging_service_unittest.cc

index 31a6d9e471e68f2885f9405e105034eea3e375f0..0e49adfda4b107f885138f28b5cd1e01e4c88ce5 100644

--- a/chrome/browser/push_messaging/push_messaging_service_unittest.cc

+++ b/chrome/browser/push_messaging/push_messaging_service_unittest.cc

@@ -158,8 +158,11 @@ TEST_F(PushMessagingServiceTest, PayloadEncryptionTest) {

// (2) Subscribe for Push Messaging, and verify that we've got the required

// information in order to be able to create encrypted messages.

+ content::PushSubscriptionOptions options;

+ options.user_visible_only = true;

+ options.sender_info = kTestSenderId;

push_service->SubscribeFromWorker(

- origin, kTestServiceWorkerId, kTestSenderId, true /* user_visible */,

+ origin, kTestServiceWorkerId, options,

base::Bind(&PushMessagingServiceTest::DidRegister, base::Unretained(this),

&subscription_id, &p256dh, &auth));