Partial implementation of subscription restrictions.

third_party/WebKit/Source/modules/push_messaging/PushManager.cpp

Index: third_party/WebKit/Source/modules/push_messaging/PushManager.cpp
diff --git a/third_party/WebKit/Source/modules/push_messaging/PushManager.cpp b/third_party/WebKit/Source/modules/push_messaging/PushManager.cpp
index 0f5a2ffd66ddd641444c5580ef3b4c3273ccc98d..9b0fc3f2e5de5807d59ce1cea47a457f715bb042 100644
--- a/third_party/WebKit/Source/modules/push_messaging/PushManager.cpp
+++ b/third_party/WebKit/Source/modules/push_messaging/PushManager.cpp
@@ -38,6 +38,8 @@ WebPushSubscriptionOptions toWebPushSubscriptionOptions(const PushSubscriptionOp
 {
     WebPushSubscriptionOptions webOptions;
     webOptions.userVisibleOnly = options.userVisibleOnly();
+    if (options.hasAppServicePublicKey() && options.appServicePublicKey())
+        webOptions.applicationServerKey = WTF::String(static_cast<const char*>(options.appServicePublicKey()->data()));

[Peter Beverloo, 2016/02/17 16:15:36]

This isn't safe because the |applicationServerKey| may contain NULL bytes, which
would early-terminate the string. We need to use the length (byteLength())
explicitly.

I think we have two options here—

  (1) Store and pass the key as a WebVector<uint8_t>.
  (2) Creating a UTF16 string out of the binary data so that we can convert it
back to a UTF8 string (i.e. std::string) later on.


webOptions.applicationServerKey = WebString::fromUTF8(
    static_cast<const char*>(options.applicationServerKey()->data(),
                             options.applicationServerKey()->byteLength()));

[harkness, 2016/02/18 10:45:15]

Done.

     return webOptions;
 }