Partial implementation of subscription restrictions.

third_party/WebKit/Source/modules/push_messaging/PushManager.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PushManager_h
 #define PushManager_h
 
 #include "bindings/core/v8/ScriptWrappable.h"
+#include "bindings/modules/v8/UnionTypesModules.h"
 #include "platform/heap/Handle.h"
 
 namespace blink {
 
 class PushSubscriptionOptions;
 class ScriptPromise;
 class ScriptState;
 class ServiceWorkerRegistration;
+struct WebPushSubscriptionOptions;
 
 class PushManager final : public GarbageCollected<PushManager>, public ScriptWrappable {
     DEFINE_WRAPPERTYPEINFO();
 public:
     static PushManager* create(ServiceWorkerRegistration* registration)
     {
         return new PushManager(registration);
     }
 
     ScriptPromise subscribe(ScriptState*, const PushSubscriptionOptions&);
     ScriptPromise getSubscription(ScriptState*);
     ScriptPromise permissionState(ScriptState*, const PushSubscriptionOptions&);
 
     DECLARE_TRACE();
 
+    static String toString(const ArrayBufferOrArrayBufferView& applicationServerKey);

[Peter Beverloo, 2016/02/23 14:28:29]

Two thoughts:

  (1) We could avoid exposing this altogether if we were to test the
toWebPushSubscriptionOptions entry point instead. That would further allow us to
have basic test coverage of the `userVisibleOnly` boolean, and potentially other
future values.

  (2) If you would like to expose this, let's pick a clear name. Right now, this
reads as "PushManager::toString(..)", which causes ambiguity with
`pushManager.toString()` (which is completely valid JavaScript), while it does
something completely different.

+
 private:
     explicit PushManager(ServiceWorkerRegistration*);
+    static WebPushSubscriptionOptions toWebPushSubscriptionOptions(
+        const PushSubscriptionOptions&);
 
     Member<ServiceWorkerRegistration> m_registration;
 };
 
 } // namespace blink
 
 #endif // PushManager_h