third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.idl - Issue 1701313002: Partial implementation of subscription restrictions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.idl

Issue 1701313002: Partial implementation of subscription restrictions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed broken file Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/renderer/push_messaging/push_messaging_dispatcher.cc ('K') | « third_party/WebKit/Source/modules/push_messaging/PushManager.cpp ('k') | third_party/WebKit/public/platform/modules/push_messaging/WebPushSubscriptionOptions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://w3c.github.io/push-api/#idl-def-PushSubscriptionOptions	5 // https://w3c.github.io/push-api/#idl-def-PushSubscriptionOptions

6	6

7 dictionary PushSubscriptionOptions {	7 dictionary PushSubscriptionOptions {

8 boolean userVisibleOnly = false;	8 boolean userVisibleOnly = false;

	9 ArrayBuffer applicationServerKey;
	Peter Beverloo 2016/02/18 11:39:43 As discussed, we'll want to hide this behind a fea As discussed, we'll want to hide this behind a feature flag annotation until the feature can be shipped, e.g. [RuntimeEnabled=PushSubscriptionRestrictions], whereas PushSubscriptionRestrictions can be enabled with the Enable Experimental Web Platform Features command-line flag. This gives us four possible values for the `applicationServerKey` property in C++: (1) Feature flag disabled, developer does not provide `applicationServerKey`: NULL. (2) Feature flag disabled, developer provides `applicationServerKey`: NULL. (3) Feature flag enabled, developer does not provide `applicationServerKey`: NULL. (4) Feature flag enabled, developer provides `applicationServerKey`: BufferSource value. Peter Beverloo 2016/02/18 11:39:43 Per the spec, this has to be of type BufferSource, Per the spec, this has to be of type BufferSource, which is an ArrayBuffer or an ArrayBufferView. We have the typedef in CommonDefinitions.idl already, so you should be able to use it directly. You could extract the IDL value -> (Web)String conversion to a helper method that abstracts this away from the main flow. String toString(const ArrayBufferOrArrayBufferView& applicationServerKey) { if (applicationServerKey.isArrayBuffer()) { ... } else if (applicationServerKey.isArrayBufferView()) { ... } else { Oops!(); } } harkness 2016/02/22 15:40:43 Should be good now? Show quoted text On 2016/02/18 11:39:43, Peter Beverloo wrote: > Per the spec, this has to be of type BufferSource, which is an ArrayBuffer or > an ArrayBufferView. > > We have the typedef in CommonDefinitions.idl already, so you should be able to > use it directly. You could extract the IDL value -> (Web)String conversion to a > helper method that abstracts this away from the main flow. > > String toString(const ArrayBufferOrArrayBufferView& applicationServerKey) { > if (applicationServerKey.isArrayBuffer()) { ... } > else if (applicationServerKey.isArrayBufferView()) { ... } > else { Oops!(); } > } Should be good now?
9 };	10 };

OLD	NEW