Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: third_party/WebKit/Source/modules/vr/VREyeParameters.h

Issue 1701283002: Implement DOMPoint using v8 extras. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/vr/VREyeParameters.h
diff --git a/third_party/WebKit/Source/modules/vr/VREyeParameters.h b/third_party/WebKit/Source/modules/vr/VREyeParameters.h
index eea6c5675dc3cf2c9c629a732fab57359776361f..370215ce324ec702eb9298482f76b4723fbbfb07 100644
--- a/third_party/WebKit/Source/modules/vr/VREyeParameters.h
+++ b/third_party/WebKit/Source/modules/vr/VREyeParameters.h
@@ -6,7 +6,6 @@
#define VREyeParameters_h
#include "bindings/core/v8/ScriptWrappable.h"
-#include "core/dom/DOMPoint.h"
#include "core/dom/DOMRect.h"
#include "modules/vr/VRFieldOfView.h"
#include "platform/heap/Handle.h"
@@ -15,7 +14,7 @@
namespace blink {
-class VREyeParameters final : public GarbageCollected<VREyeParameters>, public ScriptWrappable {
+class VREyeParameters final : public GarbageCollectedFinalized<VREyeParameters>, public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();
public:
static VREyeParameters* create()
@@ -26,7 +25,7 @@ public:
VRFieldOfView* minimumFieldOfView() const { return m_minimumFieldOfView; }
VRFieldOfView* maximumFieldOfView() const { return m_maximumFieldOfView; }
VRFieldOfView* recommendedFieldOfView() const { return m_recommendedFieldOfView; }
- DOMPoint* eyeTranslation() const { return m_eyeTranslation; }
+ ScriptValue& eyeTranslation(ScriptState*);
VRFieldOfView* currentFieldOfView() const { return m_currentFieldOfView; }
DOMRect* renderRect() const { return m_renderRect; }
@@ -40,7 +39,8 @@ private:
Member<VRFieldOfView> m_minimumFieldOfView;
Member<VRFieldOfView> m_maximumFieldOfView;
Member<VRFieldOfView> m_recommendedFieldOfView;
- Member<DOMPoint> m_eyeTranslation;
+ ScriptValue m_eyeTranslation;
+ WebVRVector3 m_eyeTranslationVector;
Member<VRFieldOfView> m_currentFieldOfView;
Member<DOMRect> m_renderRect;

Powered by Google App Engine
This is Rietveld 408576698