Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 1701273003: [builtins] Migrate the leftover Boolean setup to C++. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Migrate the leftover Boolean setup to C++. There's no point in having the setup or the toString/valueOf methods in JavaScript. The full setup can be done during bootstrapping when the Boolean constructor is created, and the prototype methods don't benefit from JS + %_ at all. R=jarin@chromium.org Committed: https://crrev.com/6de9b9ce5b3aa46ca183b0da4c55c567dee9ced1 Cr-Commit-Position: refs/heads/master@{#34068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -39 lines) Patch
M src/bootstrapper.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/builtins.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M src/js/v8natives.js View 2 chunks +0 lines, -39 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-17 09:59:53 UTC) #1
Benedikt Meurer
Hey Jaro, Here's another quick one. Please take a look. Thanks, Benedikt
4 years, 10 months ago (2016-02-17 10:01:04 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701273003/1
4 years, 10 months ago (2016-02-17 10:03:25 UTC) #4
Jarin
lgtm
4 years, 10 months ago (2016-02-17 10:22:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701273003/1
4 years, 10 months ago (2016-02-17 10:31:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 10:36:01 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 10:36:57 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6de9b9ce5b3aa46ca183b0da4c55c567dee9ced1
Cr-Commit-Position: refs/heads/master@{#34068}

Powered by Google App Engine
This is Rietveld 408576698