Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/browser/extensions/api/image_writer_private/image_writer_utils.cc

Issue 170123002: Revert of Significantly cleans up the ImageWriter Operation class and subclasses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/image_writer_private/image_writer_utils.cc
diff --git a/chrome/browser/extensions/api/image_writer_private/image_writer_utils.cc b/chrome/browser/extensions/api/image_writer_private/image_writer_utils.cc
new file mode 100644
index 0000000000000000000000000000000000000000..4905cb6ce77ff17de0d95a2e96d60562748e18bd
--- /dev/null
+++ b/chrome/browser/extensions/api/image_writer_private/image_writer_utils.cc
@@ -0,0 +1,127 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/logging.h"
+#include "chrome/browser/extensions/api/image_writer_private/image_writer_utils.h"
+
+namespace extensions {
+namespace image_writer_utils
+{
+
+const int kFsyncRatio = 1024;
+
+ImageWriter::ImageWriter() : file_(base::kInvalidPlatformFileValue),
+ writes_count_(0) {
+}
+
+ImageWriter::~ImageWriter() {
+ if (file_ != base::kInvalidPlatformFileValue)
+ base::ClosePlatformFile(file_);
+}
+
+bool ImageWriter::Open(const base::FilePath& path) {
+ if (file_ != base::kInvalidPlatformFileValue)
+ Close();
+ DCHECK_EQ(base::kInvalidPlatformFileValue, file_);
+ base::PlatformFileError error;
+ file_ = base::CreatePlatformFile(
+ path,
+ base::PLATFORM_FILE_OPEN | base::PLATFORM_FILE_WRITE,
+ NULL,
+ &error);
+ if (error != base::PLATFORM_FILE_OK) {
+ LOG(ERROR) << "Couldn't open target path "
+ << path.value() << ": " << error;
+ return false;
+ }
+ return true;
+}
+
+bool ImageWriter::Close() {
+ if (file_ != base::kInvalidPlatformFileValue &&
+ base::ClosePlatformFile(file_)) {
+ file_ = base::kInvalidPlatformFileValue;
+ return true;
+ } else {
+ LOG(ERROR) << "Could not close target file";
+ return false;
+ }
+}
+
+int ImageWriter::Write(const char* data_block, int data_size) {
+ int written = base::WritePlatformFileAtCurrentPos(file_, data_block,
+ data_size);
+ if (written != data_size) {
+ LOG(ERROR) << "Error writing to target file";
+ return -1;
+ }
+
+ writes_count_++;
+ if (writes_count_ == kFsyncRatio) {
+ if (!base::FlushPlatformFile(file_)) {
+ LOG(ERROR) << "Error syncing target file";
+ return -1;
+ }
+ writes_count_ = 0;
+ }
+
+ return written;
+}
+
+ImageReader::ImageReader() : file_(base::kInvalidPlatformFileValue) {
+}
+
+ImageReader::~ImageReader() {
+ if (file_ != base::kInvalidPlatformFileValue)
+ base::ClosePlatformFile(file_);
+}
+
+bool ImageReader::Open(const base::FilePath& path) {
+ if (file_ != base::kInvalidPlatformFileValue)
+ Close();
+ DCHECK_EQ(base::kInvalidPlatformFileValue, file_);
+ base::PlatformFileError error;
+ file_ = base::CreatePlatformFile(
+ path,
+ base::PLATFORM_FILE_OPEN | base::PLATFORM_FILE_READ,
+ NULL,
+ &error);
+ if (error != base::PLATFORM_FILE_OK) {
+ LOG(ERROR) << "Couldn't open target path "
+ << path.value() << ": " << error;
+ return false;
+ }
+ return true;
+}
+
+bool ImageReader::Close() {
+ if (file_ != base::kInvalidPlatformFileValue &&
+ base::ClosePlatformFile(file_)) {
+ file_ = base::kInvalidPlatformFileValue;
+ return true;
+ } else {
+ LOG(ERROR) << "Could not close target file";
+ return false;
+ }
+ return true;
+}
+
+int ImageReader::Read(char* data_block, int data_size) {
+ int read = base::ReadPlatformFileAtCurrentPos(file_, data_block, data_size);
+ if (read < 0)
+ LOG(ERROR) << "Error reading from source file";
+ return read;
+}
+
+int64 ImageReader::GetSize() {
+ base::PlatformFileInfo info;
+ if (base::GetPlatformFileInfo(file_, &info)) {
+ return info.size;
+ } else {
+ return 0;
+ }
+}
+
+} // namespace image_writer_utils
+} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698