Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 170123002: Revert of Significantly cleans up the ImageWriter Operation class and subclasses. (Closed)

Created:
6 years, 10 months ago by ckocagil
Modified:
6 years, 10 months ago
Reviewers:
tbarzic, Drew Haven
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Significantly cleans up the ImageWriter Operation class and subclasses. (https://codereview.chromium.org/149313003/) Reason for revert: Broke ASAN bots. http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%282%29/builds/23085/steps/unit_tests/logs/DownloadFile Original issue's description: > Significantly cleans up the ImageWriter Operation class and subclasses. > > * Moved Operations to be in CPS for stage isolation. > * Updates unit tests to use isolated stages. > * Adds unit tests for uncovered stages. > * Cleans up temporary file handling. > * Removes unnecessary and redundant code (CompareFiles, ImageReader). > * Fixes bug with verification progress updates. > * All .zip files now unzipped before burning. > * All non-.zip files not unzipped before burning. > * Removes unnecessary complexity, e.g. unnecessary scoped_ptrs. > > BUG=292956 > BUG=337883 > BUG=335404 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251704 TBR=tbarzic@chromium.org,haven@chromium.org NOTREECHECKS=true NOTRY=true BUG=292956 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251729

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+941 lines, -1028 lines) Patch
M chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation.cc View 2 chunks +10 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation_unittest.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc View 3 chunks +18 lines, -5 lines 0 comments Download
A chrome/browser/extensions/api/image_writer_private/image_writer_utils.h View 1 chunk +53 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/image_writer_private/image_writer_utils.cc View 1 chunk +127 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation.h View 6 chunks +29 lines, -43 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation.cc View 6 chunks +158 lines, -173 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_chromeos.cc View 1 chunk +17 lines, -24 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_linux.cc View 1 chunk +162 lines, -144 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_manager.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_manager.cc View 7 chunks +18 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_unittest.cc View 2 chunks +61 lines, -175 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/test_utils.h View 2 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/test_utils.cc View 2 chunks +27 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/write_from_file_operation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/write_from_file_operation.cc View 1 chunk +11 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/write_from_file_operation_unittest.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/write_from_url_operation.h View 2 chunks +32 lines, -41 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc View 4 chunks +192 lines, -123 lines 0 comments Download
D chrome/browser/extensions/api/image_writer_private/write_from_url_operation_unittest.cc View 1 chunk +0 lines, -204 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ckocagil
Created Revert of Significantly cleans up the ImageWriter Operation class and subclasses.
6 years, 10 months ago (2014-02-18 04:56:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckocagil@chromium.org/170123002/1
6 years, 10 months ago (2014-02-18 04:56:44 UTC) #2
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 04:57:10 UTC) #3
Message was sent while issue was closed.
Change committed as 251729

Powered by Google App Engine
This is Rietveld 408576698