[fusl] Build example apptests under fusl

[fusl] Build example apptests under fusl

R=viettrungluu@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/40c700d9b8da5bc6cc4cceec406b1aa4f48e986b

[viettrungluu, 2016-02-17 00:09:14]

https://codereview.chromium.org/1701193002/diff/1/mojo/tools/data/fusl_apptests
File mojo/tools/data/fusl_apptests (right):

https://codereview.chromium.org/1701193002/diff/1/mojo/tools/data/fusl_apptes...
mojo/tools/data/fusl_apptests:1: # This file contains a list of Mojo apptests.
For description of the file
What's this file and why?

[kulakowski, 2016-02-17 00:46:49]

On 2016/02/17 00:09:14, viettrungluu wrote:
>
https://codereview.chromium.org/1701193002/diff/1/mojo/tools/data/fusl_apptests
> File mojo/tools/data/fusl_apptests (right):
> 
>
https://codereview.chromium.org/1701193002/diff/1/mojo/tools/data/fusl_apptes...
> mojo/tools/data/fusl_apptests:1: # This file contains a list of Mojo apptests.
> For description of the file
> What's this file and why?

I don't know how the apptests are actually run on the bots. So I had just copied
the apptests file and uploaded it to see what would happen. I hadn't intended to
actually submit this for review yet. The intention is to build some of these
things to run under fusl.

[kulakowski, 2016-02-17 21:31:07]

https://codereview.chromium.org/1701193002/diff/20001/mojo/tools/data/fusl_ap...
File mojo/tools/data/fusl_apptests (right):

https://codereview.chromium.org/1701193002/diff/20001/mojo/tools/data/fusl_ap...
mojo/tools/data/fusl_apptests:9: tests = [
This is all tests that can run without having to build stuff under //mojo w/
fusl, for now.

https://codereview.chromium.org/1701193002/diff/20001/services/icu_data/BUILD.gn
File services/icu_data/BUILD.gn (right):

https://codereview.chromium.org/1701193002/diff/20001/services/icu_data/BUILD...
services/icu_data/BUILD.gn:10: source = "$root_out_dir/icudtl.dat"
This doesn't change the location for the standard toolchain, and puts it in the
correct place if you override the toolchain.

[viettrungluu, 2016-02-17 22:18:05]

https://codereview.chromium.org/1701193002/diff/20001/mojo/devtools/common/mo...
File mojo/devtools/common/mojo_test (right):

https://codereview.chromium.org/1701193002/diff/20001/mojo/devtools/common/mo...
mojo/devtools/common/mojo_test:83: shell_dir =
os.path.dirname(config.shell_path)
I think you should just plumb through shell_path, especially since you're
already doing an os.path.join() in the test list.

https://codereview.chromium.org/1701193002/diff/20001/mojo/tools/data/fusl_ap...
File mojo/tools/data/fusl_apptests (right):

https://codereview.chromium.org/1701193002/diff/20001/mojo/tools/data/fusl_ap...
mojo/tools/data/fusl_apptests:4: import os
Maybe just "import os.path"?

https://codereview.chromium.org/1701193002/diff/20001/mojo/tools/data/fusl_ap...
mojo/tools/data/fusl_apptests:9: tests = [
On 2016/02/17 21:31:07, kulakowski wrote:
> This is all tests that can run without having to build stuff under //mojo w/
> fusl, for now.

Please update the comment at the top of the file.

Also, include a "TODO" to somehow merge this back into the main apptest list.
(Probably stop building various things for both fusl and non-fusl, and figure
out how they can share a universe of apps.)

https://codereview.chromium.org/1701193002/diff/20001/mojo/tools/get_test_lis...
File mojo/tools/get_test_list.py (right):

https://codereview.chromium.org/1701193002/diff/20001/mojo/tools/get_test_lis...
mojo/tools/get_test_list.py:110: # Fusl app tests (Linux excluding Android)
nit: comment needs ':'

Also, I'd stick this block either before the two NaCl ones or after both of them
(I'd vote for before, but whatever).

[kulakowski, 2016-02-17 22:41:52]

https://codereview.chromium.org/1701193002/diff/20001/mojo/devtools/common/mo...
File mojo/devtools/common/mojo_test (right):

https://codereview.chromium.org/1701193002/diff/20001/mojo/devtools/common/mo...
mojo/devtools/common/mojo_test:83: shell_dir =
os.path.dirname(config.shell_path)
On 2016/02/17 22:18:04, viettrungluu wrote:
> I think you should just plumb through shell_path, especially since you're
> already doing an os.path.join() in the test list.

Done.

https://codereview.chromium.org/1701193002/diff/20001/mojo/tools/data/fusl_ap...
File mojo/tools/data/fusl_apptests (right):

https://codereview.chromium.org/1701193002/diff/20001/mojo/tools/data/fusl_ap...
mojo/tools/data/fusl_apptests:4: import os
On 2016/02/17 22:18:04, viettrungluu wrote:
> Maybe just "import os.path"?

Done.

https://codereview.chromium.org/1701193002/diff/20001/mojo/tools/data/fusl_ap...
mojo/tools/data/fusl_apptests:9: tests = [
On 2016/02/17 22:18:04, viettrungluu wrote:
> On 2016/02/17 21:31:07, kulakowski wrote:
> > This is all tests that can run without having to build stuff under //mojo w/
> > fusl, for now.
> 
> Please update the comment at the top of the file.
> 
> Also, include a "TODO" to somehow merge this back into the main apptest list.
> (Probably stop building various things for both fusl and non-fusl, and figure
> out how they can share a universe of apps.)

Done.

https://codereview.chromium.org/1701193002/diff/20001/mojo/tools/get_test_lis...
File mojo/tools/get_test_list.py (right):

https://codereview.chromium.org/1701193002/diff/20001/mojo/tools/get_test_lis...
mojo/tools/get_test_list.py:110: # Fusl app tests (Linux excluding Android)
On 2016/02/17 22:18:04, viettrungluu wrote:
> nit: comment needs ':'
> 
> Also, I'd stick this block either before the two NaCl ones or after both of
them
> (I'd vote for before, but whatever).

Done.

[kulakowski, 2016-02-18 22:40:11]

On 2016/02/17 22:41:52, kulakowski wrote:
>
https://codereview.chromium.org/1701193002/diff/20001/mojo/devtools/common/mo...
> File mojo/devtools/common/mojo_test (right):
> 
>
https://codereview.chromium.org/1701193002/diff/20001/mojo/devtools/common/mo...
> mojo/devtools/common/mojo_test:83: shell_dir =
> os.path.dirname(config.shell_path)
> On 2016/02/17 22:18:04, viettrungluu wrote:
> > I think you should just plumb through shell_path, especially since you're
> > already doing an os.path.join() in the test list.
> 
> Done.
> 
>
https://codereview.chromium.org/1701193002/diff/20001/mojo/tools/data/fusl_ap...
> File mojo/tools/data/fusl_apptests (right):
> 
>
https://codereview.chromium.org/1701193002/diff/20001/mojo/tools/data/fusl_ap...
> mojo/tools/data/fusl_apptests:4: import os
> On 2016/02/17 22:18:04, viettrungluu wrote:
> > Maybe just "import os.path"?
> 
> Done.
> 
>
https://codereview.chromium.org/1701193002/diff/20001/mojo/tools/data/fusl_ap...
> mojo/tools/data/fusl_apptests:9: tests = [
> On 2016/02/17 22:18:04, viettrungluu wrote:
> > On 2016/02/17 21:31:07, kulakowski wrote:
> > > This is all tests that can run without having to build stuff under //mojo
w/
> > > fusl, for now.
> > 
> > Please update the comment at the top of the file.
> > 
> > Also, include a "TODO" to somehow merge this back into the main apptest
list.
> > (Probably stop building various things for both fusl and non-fusl, and
figure
> > out how they can share a universe of apps.)
> 
> Done.
> 
>
https://codereview.chromium.org/1701193002/diff/20001/mojo/tools/get_test_lis...
> File mojo/tools/get_test_list.py (right):
> 
>
https://codereview.chromium.org/1701193002/diff/20001/mojo/tools/get_test_lis...
> mojo/tools/get_test_list.py:110: # Fusl app tests (Linux excluding Android)
> On 2016/02/17 22:18:04, viettrungluu wrote:
> > nit: comment needs ':'
> > 
> > Also, I'd stick this block either before the two NaCl ones or after both of
> them
> > (I'd vote for before, but whatever).
> 
> Done.

PTAL

In particular, with the rebase on top of the goma fix, the builds take ~10
instead of ~30 minutes again!

[viettrungluu, 2016-02-19 22:13:49]

lgtm

[kulakowski, 2016-02-19 23:12:18]

Description was changed from

==========
[fusl] Build example apptests under fusl

R=viettrungluu@chromium.org
==========

to

==========
[fusl] Build example apptests under fusl

R=viettrungluu@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/40c700d9b8da5bc6cc4cceec406...
==========

[kulakowski, 2016-02-19 23:12:20]

Committed patchset #6 (id:100001) manually as
40c700d9b8da5bc6cc4cceec406b1aa4f48e986b (presubmit successful).